Closed (fixed)
Project:
Nodequeue
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Jan 2015 at 15:30 UTC
Updated:
29 Aug 2015 at 08:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pau1_m commentedComment #2
pau1_m commentedIt appears that apachesolr module 1.7 does not use variable_set to store indexing variables and instead puts them in the table apachesolr_environment_variable. Nodequeue is calling variable_get to retrieve values that will never exist.
Comment #3
fizk commented@pau1_m Do you know which version of apachesolr made the switch to using apachesolr_environment_variable?
Comment #4
charginghawk commentedIt looks like this is the patch that made the change:
https://www.drupal.org/node/1953976#comment-7252596http://cgit.drupalcode.org/apachesolr/commit/?id=a5e0c4aa1a137984a839006...
https://www.drupal.org/node/1349532
Edit: Link changes
Comment #5
charginghawk commentedI've submitted an apachesolr patch that alleviates this issue - there's a switch in there that's blocking hook_form_alter values:
#2492427: Switch in apachesolr_search_bias_form_submit blocking hook_form_alter values
Meanwhile, I'm attaching a patch that in conjunction with the above apachesolr patch allows you to change and save settings.
This is only a partial fix, because the changed setting aren't having any impact on search results that I can see. A complete fix probably involves updating the nodequeue_apachesolr_query_alter function to use apachesolr_environment_variable_get instead of variable_get.
Comment #6
charginghawk commentedHere's a patch that gets it another step closer. If you remove the switch in the apachesolr function, and apply this patch to nodequeue, then the integration works. You can set bias, and see its effect in the search results.
Unfortunately, it doesn't look like apachesolr's going to accept my patch, so before this is truly complete, an additional submit handler has to be added to save the variables.
Comment #7
charginghawk commentedHere's the third iteration, a complete patch - with the addition of an extra submit handler, it can now independently get apachesolr integration up and running. Some code cobwebs had to be dusted out, but I've tested this and can say it works like a charm.
Comment #8
caspervoogt commentedthe patch from #7 worked for me. Thanks charginghawk!
Comment #10
fizk commentedThanks! Committed.