Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.#1900068: Replace 'self' reference with '$view->name:$view->current_display' updates the the dv sort handler to replace 'self' with 'view_name:view_display_name' in the code. Existing views will still have 'self' in the db.
We should implement hook_update_N() to change this setting for existing views.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | default_self_view_2413433.txt | 4.76 KB | istryker |
| #8 | draggableviews-2413433-update-sort-settings-8.patch | 2.57 KB | istryker |
| #3 | draggableviews-2413433-update-sort-settings-3.patch | 2.54 KB | calebtr |
Comments
Comment #1
calebtr commentedAnd here is a patch.
Comment #2
calebtr commentedProperly choosing the key for the DraggableViews sort.
Comment #3
calebtr commentedI had forgotten to pass the $view to _draggableviews_get_draggable_sort().
Comment #4
istryker commentedThis needs to go into 7.x-2.1 for sure
Comment #5
istryker commentedAdded to #1913130: META: Plan for Draggable Views 7.x-2.1 release
Comment #6
istryker commentedThis is pushed to 7.x-2.2
Comment #7
joelpittetComment #8
istryker commentedRe-roll
Comment #9
istryker commentedI do not have an old site to test this, what is the best way to test if this update_hook() works.
Comment #10
calebtr commentedPerhaps:
- fresh installation of drupal
- devel gen some nodes
- clone the draggableviews repo and check out the commit before a5e5103 (https://www.drupal.org/node/1900068)
- create a draggable view and save an order
- check out HEAD on the draggableviews repo
- apply the patch here
- run the update
- verify that view order is intact
Comment #11
istryker commentedrevert to ab246d4 (one before), tried attached view and it does not get rid of the 'self' in the default display with patch 8