#1900068: Replace 'self' reference with '$view->name:$view->current_display' updates the the dv sort handler to replace 'self' with 'view_name:view_display_name' in the code. Existing views will still have 'self' in the db.

We should implement hook_update_N() to change this setting for existing views.

CommentFileSizeAuthor
#11 default_self_view_2413433.txt4.76 KBistryker
#8 draggableviews-2413433-update-sort-settings-8.patch2.57 KBistryker
#1 draggableviews-2413433-update-self-sort-setting-1.patch2.47 KBcalebtr
#2 draggableviews-2413433-1-2-interdiff.patch629 bytescalebtr
#2 draggableviews-2413433-update-sort-settings-2.patch2.53 KBcalebtr
#3 draggableviews-2413433-update-sort-settings-2-3-interdiff.patch581 bytescalebtr
#3 draggableviews-2413433-update-sort-settings-3.patch2.54 KBcalebtr

Comments

calebtr’s picture

calebtr commented
Title: update 'self' sort handler in db » update 'self' sort handler setting in db
Status: Active » Needs review
StatusFileSize
new draggableviews-2413433-update-self-sort-setting-1.patch2.47 KB

And here is a patch.

calebtr’s picture

calebtr commented
StatusFileSize
new draggableviews-2413433-1-2-interdiff.patch629 bytes
new draggableviews-2413433-update-sort-settings-2.patch2.53 KB

Properly choosing the key for the DraggableViews sort.

calebtr’s picture

calebtr commented
StatusFileSize
new draggableviews-2413433-update-sort-settings-3.patch2.54 KB
new draggableviews-2413433-update-sort-settings-2-3-interdiff.patch581 bytes

I had forgotten to pass the $view to _draggableviews_get_draggable_sort().

istryker’s picture

istryker commented

This needs to go into 7.x-2.1 for sure

istryker’s picture

istryker commented
Related issues: +#1913130: META: Plan for Draggable Views 7.x-2.1 release

Added to #1913130: META: Plan for Draggable Views 7.x-2.1 release

istryker’s picture

istryker commented
Parent issue: » #2445089: Plan for Draggable Views 7.x-2.2 release
Related issues: -#1913130: META: Plan for Draggable Views 7.x-2.1 release

This is pushed to 7.x-2.2

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
istryker’s picture

istryker commented
StatusFileSize
new draggableviews-2413433-update-sort-settings-8.patch2.57 KB

Re-roll

istryker’s picture

istryker commented

I do not have an old site to test this, what is the best way to test if this update_hook() works.

calebtr’s picture

calebtr commented

Perhaps:

- fresh installation of drupal
- devel gen some nodes
- clone the draggableviews repo and check out the commit before a5e5103 (https://www.drupal.org/node/1900068)
- create a draggable view and save an order
- check out HEAD on the draggableviews repo
- apply the patch here
- run the update
- verify that view order is intact

istryker’s picture

istryker commented
Status: Needs review » Needs work
StatusFileSize
new default_self_view_2413433.txt4.76 KB

revert to ab246d4 (one before), tried attached view and it does not get rid of the 'self' in the default display with patch 8