Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The Joyride JavaScript library created by zurb (https://github.com/zurb/joyride) has been incorporated into the "zurb Foundation" project (https://github.com/zurb/foundation), and as a result is no longer maintained as a separate entity. This means that the current jquery-joyride asset library used by Drupal uses an old version (~18 months as of January 2015) that is no longer maintained.
Proposed resolution
Determine the impact of incorporating Joyride from the zurb Foundation library into Drupal. This would probably involve using only a few files from the zurb Foundation project, as the project in its entirety is quite large and outside the scope of the Tour module. If it seems beneficial, incorporate the Joyride plugin and other necessary parts of zurb Foundation into Drupal's asset libraries to upgrade the current jquery-joyride asset.
Remaining tasks
- Clean up CSS styling
- Clean up JavaScript code
User interface changes
- Adds "Previous" button to Tour tips
API changes
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | interdiff-2409861-1-2.txt | 3.28 KB | hampercm |
| #1 | joyride-foundation-2409861-1-do-not-test.patch | 68.06 KB | hampercm |
Comments
Comment #1
hampercm CreditAttribution: hampercm commentedIt looks like Joyride from zurb Foundation v5.5.0 can be incorporated into Drupal with the inclusion of just 2 JavaScript files from the Foundation project: foundation.js and foundation.joyride.js.
Here's a quick-and-dirty first attempt at getting things going. It looks quite promising, and may be much simpler to integrate than I had previously expected.
One point of concern may be the apparent lack of ARIA support, though I may just be missing something on getting that going.
Comment #2
hampercm CreditAttribution: hampercm commentedThis patch fixes a number of CSS styling and functionality issues. Looking much better now.
Comment #3
rodrigoaguileralet's tets it
Comment #4
rodrigoaguileraComment #5
rodrigoaguileraSorry, I'm stupid
I was following the track on why there's no previous button on the tours since we talked about it here
#2017471: Multilingual tour for language section
Comment #6
rodrigoaguileraI did some testing and looks great.
I found two issues that are probably a problem upstream:
- Find a previous button on the first tip
- When I close the tour tip (x) I need to click twice on "tour" to resume it.
I think it needs updating to the latest version 5.5.1 before going in.
Do we need to provide the js minified like joyride 2.1 was?
Was left to do before we can get it in?
Comment #8
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedAs of Foundation v6, Joyride has been moved outside of Foundation Core once again, as explained here: joyride 3.0.
Joyride is now maintained as a stand-alone library at github.com/zurb/joyride. It doesn't yet have an official stable v3.0 release, but version 2.1.0 has been tagged in the new official zurb/joyride repo. (Drupal 8.1.x currently uses Joyride v2.0.5)
Comment #11
droplet CreditAttribution: droplet commentedno critical issue as I seen in the current version. Let's add a JS testing to make sure everything is working in the future upgrade.
Comment #12
MiSc CreditAttribution: MiSc at Wunder commentedAs Joyride has moved again, changing topic, and changing version to 8.4.x-dev. Will try to update patch if someone does not do it before me.
https://github.com/zurb/joyride/tree/v3.0
Comment #14
andypostComment #17
apadernoComment #21
nod_joyride on the way out, using shepherd instead.
closing this one.
Comment #22
andypost