Problem/Motivation

The Joyride JavaScript library created by zurb (https://github.com/zurb/joyride) has been incorporated into the "zurb Foundation" project (https://github.com/zurb/foundation), and as a result is no longer maintained as a separate entity. This means that the current jquery-joyride asset library used by Drupal uses an old version (~18 months as of January 2015) that is no longer maintained.

Proposed resolution

Determine the impact of incorporating Joyride from the zurb Foundation library into Drupal. This would probably involve using only a few files from the zurb Foundation project, as the project in its entirety is quite large and outside the scope of the Tour module. If it seems beneficial, incorporate the Joyride plugin and other necessary parts of zurb Foundation into Drupal's asset libraries to upgrade the current jquery-joyride asset.

Remaining tasks

  • Clean up CSS styling
  • Clean up JavaScript code

User interface changes

  • Adds "Previous" button to Tour tips

API changes

TBD

Comments

hampercm’s picture

It looks like Joyride from zurb Foundation v5.5.0 can be incorporated into Drupal with the inclusion of just 2 JavaScript files from the Foundation project: foundation.js and foundation.joyride.js.

Here's a quick-and-dirty first attempt at getting things going. It looks quite promising, and may be much simpler to integrate than I had previously expected.

One point of concern may be the apparent lack of ARIA support, though I may just be missing something on getting that going.

hampercm’s picture

This patch fixes a number of CSS styling and functionality issues. Looking much better now.

rodrigoaguilera’s picture

Status: Active » Needs review

let's tets it

rodrigoaguilera’s picture

rodrigoaguilera’s picture

Sorry, I'm stupid

I was following the track on why there's no previous button on the tours since we talked about it here
#2017471: Multilingual tour for language section

rodrigoaguilera’s picture

I did some testing and looks great.
I found two issues that are probably a problem upstream:

- Find a previous button on the first tip

- When I close the tour tip (x) I need to click twice on "tour" to resume it.

I think it needs updating to the latest version 5.5.1 before going in.
Do we need to provide the js minified like joyride 2.1 was?

Was left to do before we can get it in?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andrewmacpherson’s picture

As of Foundation v6, Joyride has been moved outside of Foundation Core once again, as explained here: joyride 3.0.

Joyride is now maintained as a stand-alone library at github.com/zurb/joyride. It doesn't yet have an official stable v3.0 release, but version 2.1.0 has been tagged in the new official zurb/joyride repo. (Drupal 8.1.x currently uses Joyride v2.0.5)

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

droplet’s picture

Status: Needs review » Needs work
Issue tags: +Needs JS testing

no critical issue as I seen in the current version. Let's add a JS testing to make sure everything is working in the future upgrade.

MiSc’s picture

Title: Explore replacing obsolete Joyride asset with latest version from zurb Foundation » Explore replacing obsolete Joyride asset with latest version
Version: 8.3.x-dev » 8.4.x-dev
Assigned: Unassigned » MiSc

As Joyride has moved again, changing topic, and changing version to 8.4.x-dev. Will try to update patch if someone does not do it before me.

https://github.com/zurb/joyride/tree/v3.0