* @ActionLinkType(
 *   id = "reload",
 *   label = @Translation("Normal link"),
 *   description = "A normal non-JavaScript request will be made and the
 *     current page will be reloaded."
 * )

This results in a * being output in the admin UI.

Comments

joachim’s picture

Looking at core, long description texts in annotations aren't wrapped. This is a bit of a pain: #2409863: allow long text in annotations to be wrapped.

Until that's allowed, we need to unwrap the texts :/

joachim’s picture

Issue tags: +Novice

Tagging as novice.

nripeshtrivedi’s picture

StatusFileSize
new711 bytes

Hi,

I am not sure if this is correct since it voilates the 80 charaacter limit but still going by the description above. I am submitting a patch. Please review it

nripeshtrivedi’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 2409719-UI-texts-3.patch, failed testing.

nripeshtrivedi’s picture

I am not sure how the test is failing. Any help is appreciated

joachim’s picture

The failing test isn't anything to do with this, as I get it locally too with HEAD -- something must have changed in core to break it.

joachim’s picture

> I am not sure if this is correct since it voilates the 80 charaacter limit but still going by the description above

Indeed. There's no other way to do this -- core does the same with long description texts in annotations, I checked.

Thanks for the patch!

There's more than one of these though.

This regular expression will find them (if your text editor supports searching with regexps): description = "[^"]+$

(That's looking for an annotation line where the string doesn't have a closing quote BTW.)

nripeshtrivedi’s picture

StatusFileSize
new1.26 KB

Thanks for the comments. I found out one more instance as pointed out. Pleas review the patch

nripeshtrivedi’s picture

Status: Needs work » Needs review
lokapujya’s picture

Status: Needs review » Reviewed & tested by the community
nripeshtrivedi’s picture

If you could let me know that the patch fixes the issue for this ?

lokapujya queued 9: 2409719-UI-texts-9.patch for re-testing.

lokapujya’s picture

The tests were broken due to #2410773, but we fixed the tests already.

nripeshtrivedi’s picture

Thanks for testing it again. Please let me know if you require anything on this patch further

joachim’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.