Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

Follow-up of: #2407361: Move usages of drupal_html_id() to Html::getUniqueId()

Remove the function drupal_html_id().

CommentFileSizeAuthor
#7 remove_drupal_html_id-2407397-7.patch1.66 KBmrjmd
remove_drupal_html_id.patch1.7 KBjeroent

Comments

mgifford’s picture

mgifford
he/him
Primary language English
commented

What is this postponed on? What are we waiting for?

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented

The usages of this function should first be removed in core: #2407361: Move usages of drupal_html_id() to Html::getUniqueId().

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Issue summary: View changes

Assigned to the following CR: HTML functions moved to a component

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Postponed » Needs review

Status: Needs review » Needs work

The last submitted patch, remove_drupal_html_id.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Issue tags: +Needs reroll
mrjmd’s picture

mrjmd commented
Status: Needs work » Needs review
StatusFileSize
new remove_drupal_html_id-2407397-7.patch1.66 KB

Rerolled.

mrjmd’s picture

mrjmd commented
Issue tags: -Needs reroll

Status: Needs review » Needs work

The last submitted patch, 7: remove_drupal_html_id-2407397-7.patch, failed testing.

mrjmd’s picture

mrjmd commented

Hmmm, looks like the dependent issue is re-opened at #2407361: Move usages of drupal_html_id() to Html::getUniqueId(). I guess this needs to be postponed again?

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

JeroenT queued 7: remove_drupal_html_id-2407397-7.patch for re-testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed a0b2633 on 8.0.x 
    Issue #2407397 by JeroenT, mrjmd: remove drupal_html_id()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.