While reviewing some issues a client was facing with the module, we noticed that the default views for this module sometimes incorrectly use "order status" instead of "order state", and are passed order states. This causes some issues throughout, such as some orders not showing up properly, and in general is inconsistent when views filters have a label of "order status" and are actually "order state".

Cleaning up the labeling, the comments, and the places where status is actually incorrectly will help with both functionality, and clarity for those reviewing the code later.

CommentFileSizeAuthor
#1 fixing_status_to_state-2404799-1.patch13.64 KBjnicola
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jnicola’s picture

Status: Active » Needs review
FileSize
13.64 KB

Attached is a patch we're using on a site set to go into production.

mglaman’s picture

Title: Using product status where product state should be used » Using order status where order state should be used
Priority: Normal » Major
Related issues: +#2380219: Tax reports - order statuses configuration needed

Awesome! If someone could please review and test this, I'll commit once RTBC. Linking to #2380219: Tax reports - order statuses configuration needed as in regard of the whole "status" and "state" issues across the module.

mglaman’s picture

Marking this under the beta2 release plan #2425267: [META] 4.0 Beta2 Release Plan

  • mglaman committed 1dbbb7a on 7.x-4.x authored by jnicola
    Issue #2404799 by jnicola: Using order status where order state should...
mglaman’s picture

Status: Needs review » Fixed

Thanks for patch! Just had to do some manual tweaking for Customer view - after patch said MySQL error, not sure why. But manually fixed (if you want to test post commit and make sure.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 1: fixing_status_to_state-2404799-1.patch, failed testing.

mglaman’s picture

Status: Needs work » Closed (fixed)

Moving on.