Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
While reviewing some issues a client was facing with the module, we noticed that the default views for this module sometimes incorrectly use "order status" instead of "order state", and are passed order states. This causes some issues throughout, such as some orders not showing up properly, and in general is inconsistent when views filters have a label of "order status" and are actually "order state".
Cleaning up the labeling, the comments, and the places where status is actually incorrectly will help with both functionality, and clarity for those reviewing the code later.
Comment | File | Size | Author |
---|---|---|---|
#1 | fixing_status_to_state-2404799-1.patch | 13.64 KB | jnicola |
Comments
Comment #1
jnicola CreditAttribution: jnicola commentedAttached is a patch we're using on a site set to go into production.
Comment #2
mglamanAwesome! If someone could please review and test this, I'll commit once RTBC. Linking to #2380219: Tax reports - order statuses configuration needed as in regard of the whole "status" and "state" issues across the module.
Comment #3
mglamanMarking this under the beta2 release plan #2425267: [META] 4.0 Beta2 Release Plan
Comment #5
mglamanThanks for patch! Just had to do some manual tweaking for Customer view - after patch said MySQL error, not sure why. But manually fixed (if you want to test post commit and make sure.)
Comment #8
mglamanMoving on.