Tax reports - order statuses configuration needed

Thanks for the patch! You think it'd be more effective to selectively rekey based in status versus state? What state are your statuses attached to?

I can't rember where 'processsing' status gets made (which contrib) but I know I see it often. Would like to see it still in there by default. Pending and processing use the same state, which identifies checkout has been completed - or that actions have been completed, ready to be closed out and marked 'completed'

Why don't we just use "post-checkout" states rather than having to configure statuses every time? e.g.,

$post_checkout_states = array_keys(commerce_order_statuses(array('state' => 'completed')));

$order_previous_status = in_array($post_checkout_states);

I would also recommend replacing the function commerce_reports_tax_order_statuses() with a similar $post_checkout_states array-building function.

EDIT: I'm also noticing that it appears "status" and "state" are being confused all over the Commerce Reports module, so this might be part of a larger issue.

torgosPizza, you're right they are being confused across the module. 7.x-3.x relied on the status of an order. In 7.x-4.x I have tried to move over to state. All of the Views should use state now. The more "codified" submodules may not have been - such as tax and stock. My primary goal for those was to improve code and bring it up to speed and may have missed that.

I would much rather prefer order states versus status.

Marking this under the beta2 release plan #2425267: [META] 4.0 Beta2 Release Plan

Committed! Thanks for patch.

+++ b/modules/tax/commerce_reports_tax.admin.inc
@@ -8,19 +8,47 @@
     '#type' => 'submit',
     '#value' => t('Generate all tax information'),
     '#submit' => array('commerce_reports_tax_form_submit_generate'),
   );
...
+  $values = $form_state['values'];
+  variable_set('commerce_reports_tax_order_generate_statuses', $values['commerce_reports_tax_order_generate_statuses']);
+  variable_set('commerce_reports_tax_order_statuses', $values['commerce_reports_tax_order_statuses']);
+

I added the system_settings_form_submit callback to the generate button's submit callbacks. This way we don't need to worry about variable logic in the generation callback.

Also, in reference to #4. Across the module there is discrepancy on status and state. In my opinion the Views should be based on Order State since it comes configured with no (simple) front facing configuration. Tax, however, has a front facing configuration and Order Status is much simpler than introducing Order State to user UI. AFAIK Commerce doesn't really make Order State a front facing feature, more so for back end simplification.

Moving on.