The Forum form and node displays are out of order.

In D7 the type of forum field is above the body, and the body displays above the comments.

In D8 the type of forum field is at the bottom of the form, and the body displays below the comments.

See screenshots

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because regression
Issue priority Normal because defaults are weird, but site-builder could change
Prioritized changes The main goal of this issue is usability. This is a prioritized change for the beta phase.
Disruption None
CommentFileSizeAuthor
#11 2401429-formdisplay.png62.07 KBkattekrab
#11 2401429-forum-node-display.png157.19 KBkattekrab
#7 forum-field-order.pass_.patch3.47 KBlarowlan
#6 forum-field-order.fail_.patch2.08 KBlarowlan
#2 2401429-afterpatch.png74.2 KBkattekrab
#1 2401429-forum-field-order-1.patch1.06 KBkattekrab
image5457.png387.73 KBkattekrab

Comments

kattekrab’s picture

kattekrab commented
Status: Active » Needs review
StatusFileSize
new 2401429-forum-field-order-1.patch1.06 KB

Attached patch reorders the fields on the default forum node display.

The forum node form still needs to be done.

Should we have tests to make sure the fields are in a sensible order?

kattekrab’s picture

kattekrab commented
StatusFileSize
new 2401429-afterpatch.png74.2 KB

Manual test with simplytest.me

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Component: entity system » forum.module

Nice catch! this issue belongs to forum module. Let's discuss this with @larowlan.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Yes to a test.
Also should be able to just change weight, not order?

idebr’s picture

idebr commented
Status: Needs review » Needs work
Issue tags: +Needs tests
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new forum-field-order.fail_.patch2.08 KB

Tests

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new forum-field-order.pass_.patch3.47 KB

With fix for form and removing the debug commenting in the test

The last submitted patch, 6: forum-field-order.fail_.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Priority: Major » Normal
Issue summary: View changes

Ok, green and ready for review, but don't think it's major - bumped priority and added beta-evaluation

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

kattekrab’s picture

kattekrab commented
StatusFileSize
new 2401429-forum-node-display.png157.19 KB
new 2401429-formdisplay.png62.07 KB

Lovely! Thanks @larowlan and @jibran

RTBC++

Manual test on Simplytest.me screengrabs

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 370d6fd and pushed to 8.0.x. Thanks!

Thanks for filling out the beta evaluation.

  • alexpott committed 370d6fd on 8.0.x 
    Issue #2401429 by kattekrab, larowlan: Forum form...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.