The Forum form and node displays are out of order.
In D7 the type of forum field is above the body, and the body displays above the comments.
In D8 the type of forum field is at the bottom of the form, and the body displays below the comments.
See screenshots
| Issue category | Bug because regression |
|---|---|
| Issue priority | Normal because defaults are weird, but site-builder could change |
| Prioritized changes | The main goal of this issue is usability. This is a prioritized change for the beta phase. |
| Disruption | None |
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 2401429-formdisplay.png | 62.07 KB | kattekrab |
| #11 | 2401429-forum-node-display.png | 157.19 KB | kattekrab |
| #7 | forum-field-order.pass_.patch | 3.47 KB | larowlan |
| #6 | forum-field-order.fail_.patch | 2.08 KB | larowlan |
| #2 | 2401429-afterpatch.png | 74.2 KB | kattekrab |
Comments
Comment #1
kattekrab commentedAttached patch reorders the fields on the default forum node display.
The forum node form still needs to be done.
Should we have tests to make sure the fields are in a sensible order?
Comment #2
kattekrab commentedManual test with simplytest.me
Comment #3
jibranNice catch! this issue belongs to forum module. Let's discuss this with @larowlan.
Comment #4
larowlanYes to a test.
Also should be able to just change weight, not order?
Comment #5
idebr commentedComment #6
larowlanTests
Comment #7
larowlanWith fix for form and removing the debug commenting in the test
Comment #9
larowlanOk, green and ready for review, but don't think it's major - bumped priority and added beta-evaluation
Comment #10
jibranPerfect!
Comment #11
kattekrab commentedLovely! Thanks @larowlan and @jibran
RTBC++
Manual test on Simplytest.me screengrabs
Comment #12
alexpottCommitted 370d6fd and pushed to 8.0.x. Thanks!
Thanks for filling out the beta evaluation.