Allow entity form handlers to determine the entity object they need to work with

Drupal is a complex beast, so we need that flexibility

+1, even its a little bit odd that HtmlEntityFormController really does not do a lot anymore.

Is this an opportunity to update to use route match instead, while we're touching those bits?

Sounds like a good idea, but therefore we really bettter change the API to pass in a route match object.

Note: This would make this issue a subissue from #2281619: Convert most direct usages within module code of routing related request attributes to use RouteMatchInterface instead which needs a review :P </ads>

Note: you don't need to inject it .. the route match can be accessed from the controller itself, much like the request object.

+++ b/core/tests/Drupal/Tests/Core/Entity/EntityManagerTest.php
@@ -1513,6 +1513,13 @@ public function setOperation($operation) {
+  /**
+   * {@inheritdoc}
+   */
+  public function setEntityManager($entity_manager) {
+    return $this;
+  }
+

Just because the other implementations are horrible, let's don't add bad code here

Looks good to me, found just one small nitpick.

1. +++ b/core/lib/Drupal/Core/Entity/EntityFormInterface.php
   @@ -65,6 +63,19 @@ public function getEntity();
   +   * @return \Drupal\Core\Entity\EntityInterface
   +   *   The entity object as determined from the passed-in Request.
   

   ... route match. :)

2. +++ b/core/lib/Drupal/Core/Entity/HtmlEntityFormController.php
   @@ -66,19 +66,19 @@ protected function getFormArgument(Request $request) {
   +    // Allow the entity form handler to determine the entity object from a given
   +    // request.
   +    $entity = $form_object->getEntityFromRouteMatch($route_match, $entity_type_id);
   

   just "entity form" would be enough I think, but not feeling strong about it.

Thanks, looks like @dawehner is OK with the patch, looks fine to me as well.

There are some small API changes here, but I doubt they are going to break anything as they are pretty internal and they are a part of the critical issue #2281619: Convert most direct usages within module code of routing related request attributes to use RouteMatchInterface instead, so that should be OK.

The issue summary could use a quick update for request => route match and explain why the API changes in existing code are related and OK ?

Less usage of the request object - nice one. Less usage of the request object - nice one. Committed eb25fab and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.