Problem/Motivation

In issue #1511040: Add X-UA-Compatible HTTP header support was added for Google Frame. Google Frame has been officially retired since January 1st 2014: http://blog.chromium.org/2013/06/retiring-chrome-frame.html?m=1

Related HTML5 boilerplate pull request: https://github.com/h5bp/html5-boilerplate/pull/1396

Proposed resolution

Remove the Google Frame support from the http header

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions ✓
Update the existing change record at #1511040: Add X-UA-Compatible HTTP header Instructions ✓
Manually test the patch Novice Instructions
Embed before and after screenshots in the issue summary Novice Instructions ✓

User interface changes

None

API changes

None

CommentFileSizeAuthor
#12 2399035-12.patch1.78 KBidebr
#12 interdiff-12-4.txt916 bytesidebr
#12 2399035-12.fail_.patch916 bytesidebr
#4 interdiff-2-4.txt1.08 KBidebr
#4 2399035-retire_google_frame-4.patch911 bytesidebr
#2 2399035-retire_google_frame-1.patch1.97 KBidebr
#2 2399035-1-after.png83.1 KBidebr
#2 2399035-1-before.png83.51 KBidebr

Comments

dawehner’s picture

dawehner
Primary language German
commented

Note: The corresponding code is in 

core/lib/Drupal/Core/EventSubscriber/FinishResponseSubscriber.php
idebr’s picture

idebr commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2399035-1-before.png83.51 KB
new 2399035-1-after.png83.1 KB
new 2399035-retire_google_frame-1.patch1.97 KB

Http headers before:
/2399035-1-before

Http headers after:
/2399035-1-after

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

This was pretty quick.

+++ b/core/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php
@@ -51,8 +51,8 @@ public function provideAllPreserveCase()
+                array('X-UA-Compatible' => 'IE=edge'),
+                array('X-UA-Compatible' => array('IE=edge'), 'Cache-Control' => array('no-cache')),

Note: We can't change the existing test coverage of ResponseHeaderBagTest, because this is part of symfony, not Drupal itself.
On top of that this test is fine.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new 2399035-retire_google_frame-4.patch911 bytes
new interdiff-2-4.txt1.08 KB

Updated the patch to not update vendor files, thanks dawehner :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1

The last submitted patch, 2: 2399035-retire_google_frame-1.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2399035-retire_google_frame-4.patch, failed testing.

idebr queued 4: 2399035-retire_google_frame-4.patch for re-testing.

dawehner’s picture

dawehner
Primary language German
commented

@idebr
For the next time, please have a look at https://www.drupal.org/node/2399959

idebr’s picture

idebr commented
Status: Needs work » Reviewed & tested by the community

Oh, will do. Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2399035-retire_google_frame-4.patch, failed testing.

idebr’s picture

idebr commented
Status: Needs work » Needs review
Related issues: +#462950: Mitigate the security risks that come from IE, Chrome and other browsers trying to sniff the mime type
StatusFileSize
new 2399035-12.fail_.patch916 bytes
new interdiff-12-4.txt916 bytes
new 2399035-12.patch1.78 KB

Updated the patch with the test result added today in #462950: Mitigate the security risks that come from IE, Chrome and other browsers trying to sniff the mime type .

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Still RTBC IMHO.

The last submitted patch, 12: 2399035-12.fail_.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Makes sense. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 1335489 and pushed to 8.0.x. Thanks!

  • alexpott committed 1335489 on 8.0.x 
    Issue #2399035 by idebr: Retire Google Frame support

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.