Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
In issue [#1511040] support was added for Google Frame. Google Frame has been officially retired since January 1st 2014: http://blog.chromium.org/2013/06/retiring-chrome-frame.html?m=1
Related HTML5 boilerplate pull request: https://github.com/h5bp/html5-boilerplate/pull/1396
Proposed resolution
Remove the Google Frame support from the http header
Remaining tasks
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Instructions | ✓ | |
Update the existing change record at [#1511040] | Instructions | ✓ | |
Manually test the patch | Novice | Instructions | |
Embed before and after screenshots in the issue summary | Novice | Instructions | ✓ |
User interface changes
None
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#12 | 2399035-12.patch | 1.78 KB | idebr |
#12 | interdiff-12-4.txt | 916 bytes | idebr |
#12 | 2399035-12.fail_.patch | 916 bytes | idebr |
#2 | 2399035-1-after.png | 83.1 KB | idebr |
#2 | 2399035-1-before.png | 83.51 KB | idebr |
Comments
Comment #1
dawehnerNote: The corresponding code is in
Comment #2
idebr CreditAttribution: idebr commentedHttp headers before:
Http headers after:
Comment #3
dawehnerThis was pretty quick.
Note: We can't change the existing test coverage of
ResponseHeaderBagTest
, because this is part of symfony, not Drupal itself.On top of that this test is fine.
Comment #4
idebr CreditAttribution: idebr commentedUpdated the patch to not update vendor files, thanks dawehner :)
Comment #5
dawehner+1
Comment #9
dawehner@idebr
For the next time, please have a look at https://www.drupal.org/node/2399959
Comment #10
idebr CreditAttribution: idebr commentedOh, will do. Thanks!
Comment #12
idebr CreditAttribution: idebr commentedUpdated the patch with the test result added today in #462950: Mitigate the security risks that come from IE, Chrome and other browsers trying to sniff the mime type .
Comment #13
dawehnerStill RTBC IMHO.
Comment #15
alexpottMakes sense. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 1335489 and pushed to 8.0.x. Thanks!