Problem/Motivation

In issue [#1511040] support was added for Google Frame. Google Frame has been officially retired since January 1st 2014: http://blog.chromium.org/2013/06/retiring-chrome-frame.html?m=1

Related HTML5 boilerplate pull request: https://github.com/h5bp/html5-boilerplate/pull/1396

Proposed resolution

Remove the Google Frame support from the http header

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions
Update the existing change record at [#1511040] Instructions
Manually test the patch Novice Instructions
Embed before and after screenshots in the issue summary Novice Instructions

User interface changes

None

API changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Note: The corresponding code is in

core/lib/Drupal/Core/EventSubscriber/FinishResponseSubscriber.php
idebr’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
83.51 KB
83.1 KB
1.97 KB

Http headers before:
/2399035-1-before

Http headers after:
/2399035-1-after

dawehner’s picture

Status: Needs review » Needs work

This was pretty quick.

+++ b/core/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php
@@ -51,8 +51,8 @@ public function provideAllPreserveCase()
+                array('X-UA-Compatible' => 'IE=edge'),
+                array('X-UA-Compatible' => array('IE=edge'), 'Cache-Control' => array('no-cache')),

Note: We can't change the existing test coverage of ResponseHeaderBagTest, because this is part of symfony, not Drupal itself.
On top of that this test is fine.

idebr’s picture

Status: Needs work » Needs review
FileSize
911 bytes
1.08 KB

Updated the patch to not update vendor files, thanks dawehner :)

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

+1

The last submitted patch, 2: 2399035-retire_google_frame-1.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2399035-retire_google_frame-4.patch, failed testing.

dawehner’s picture

@idebr
For the next time, please have a look at https://www.drupal.org/node/2399959

idebr’s picture

Status: Needs work » Reviewed & tested by the community

Oh, will do. Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2399035-retire_google_frame-4.patch, failed testing.

idebr’s picture

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Still RTBC IMHO.

The last submitted patch, 12: 2399035-12.fail_.patch, failed testing.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Makes sense. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 1335489 and pushed to 8.0.x. Thanks!

  • alexpott committed 1335489 on 8.0.x
    Issue #2399035 by idebr: Retire Google Frame support
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.