Comments

nightwalkr’s picture

StatusFileSize
new2.84 KB

I did a patch to enable login against Facebook API 2.2

sbilde’s picture

Thanks man.. - I was about to do a similar patch!

mrded’s picture

Does it really work? Did anyone tried it?

darrellduane’s picture

Status: Active » Needs review
darrellduane’s picture

Status: Needs review » Patch (to be ported)

I'm including this in the dev release of February 14, 2015

  • DarrellDuane committed 8dadd05 on 7.x-1.x
    The following four issues were added in a previous commit but...
quicksketch’s picture

Awesome guys! This would be great. I've been worried about this pending deadline on one of the sites I have as well.

darrellduane’s picture

I considered incorporating this into a new, to be created, 2.x release of this module, but as it turns out, there is no actual functionality change for fboauth to use Facebook API 2.2. The only change is adding '/2.2' on to the end of 'graph.facebook.com' in the url. So, I'm planning to keep it in the 1.x version of the fboauth module.

sonicthoughts’s picture

Great! Will you be releasing a 1.7 soon?

darrellduane’s picture

Yes, lets make sure the dev version doesn't have any other problems in it for another week or so and then I'll roll a 1.7

darrellduane’s picture

Version: 7.x-1.6 » 7.x-1.7
Status: Patch (to be ported) » Closed (fixed)
mrded’s picture

Status: Closed (fixed) » Needs review

I suggest to change version of the module to 7.x-2.x because new version with Facebook API 2.2 already broke following task #2149661: Users with empty mail field..

Otherwise it will break websites of users who update from 7.x-1.x to 7.x-1.7. It looks like minor update, that is not really so.

jcisio’s picture

Version: 7.x-1.7 » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

I don't think it break anything. Email is optional permission, so user can opt out it, even in v1.0. My first Facebook user without email registered on Jan 2nd 2013, long before the Facebook API 2.0 was introduced.

BTW we need to fix 6.x branch, too.

jcisio’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new3.33 KB

  • DarrellDuane committed 8dadd05 on 7.x-2.x
    The following four issues were added in a previous commit but...
AntiNSA’s picture

Is this going to be fixed for 6.x?????

AlexKirienko’s picture

I'm not sure. I have no time for this.
Maybe someone will fix it. I can commit patch with fixes.

AntiNSA’s picture

If some one fixes it and you commit it, Ill use it :)

santiwww’s picture

The patch in #14 works partially, I had to modify the file fboauth.fboauth.inc a little bit more to make it work because response from facebook come in json format, so the function fboauth_access_token has to be modified like this:

  else {
    /*
    // The result from Facebook comes back in a query-string-like format,
    // key1=value1&key2=value2. Parse into an array.
    $authentication_strings = explode('&', $authentication_result->data);
    $authentication_values = array();
    foreach ($authentication_strings as $authentication_string) {
      list($authentication_key, $authentication_value) = explode('=', $authentication_string);
      $authentication_values[$authentication_key] = $authentication_value;
    }
    */
    $authentication_values = json_decode($authentication_result->data, TRUE);
  }

Sorry but I can't provide a patch.
I hope it helps someone.