Closed (fixed)
Project:
Chaos Tool Suite (ctools)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Dec 2014 at 13:40 UTC
Updated:
30 May 2015 at 19:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
maximpodorov commentedThis patch add caching for the information calculated in ctools_entity_field_content_type_content_types(). It's used in my project and reduces amount of t() calls noticeably.
Comment #2
japerryOoh! I like the cache set on here, works good marking RTBC. See if anyone has objections, if not I'll commit it.
Comment #3
maximpodorov commentedI have several more caching patches for ctools. :)
Comment #4
kars-t commentedHi
thanks for the patch and code wise it looks fine. But aren't we missing some cache clear on change of the content types?
Comment #5
maximpodorov commentedMaybe. :)
Comment #6
mrjmd commentedComment #7
japerryKars-T is correct, we need to add the ability to clear the cache for it before I commit.
Comment #8
maximpodorov commentedI updated the patch to clear cache upon field crud operations.
The cache is also cleared when drupal_flush_all_caches() function is called (e.g. when the 'Clear all caches' button on the 'Performance' page is pressed).
BTW, the same caching can be used for entity_field_extra plugin.
Comment #9
damienmckennaThis didn't end up being included in 1.6.
Comment #10
maximpodorov commentedUnfortunately.
Comment #11
joelpittetSaves ~50 ms off my homepage load. And remove > 480 calls to the t().
Comment #12
dillix commentedWhy this excluded from 1.6?
Comment #13
joelpittet@dillix because nobody RTBC'd it before the release was made.
Comment #14
dillix commentedComment #15
joelpittetthanks, yeah this should be against dev.
Comment #17
joseph.olstad++1 for commit this and tag a 1.7 release.
Well done maximpodorov
Performance improvements like this one are worth a minor version . CPU cycles and IO saved from this patch allow people to get work done faster!
I recently spent a thousand dollars on hardware upgrades because I didn't have this patch and a few others that I recently discovered. In the past 2 months I've been made aware of about 5 patches to various contrib modules and drupal core that made a far bigger performance improvement than the thousand dollars worth of hardware upgrades.
This patch saves CPU cycles which saves electricity , which saves the environment, saves peoples time and saves money. It's well worth a minor version.
Comment #18
maximpodorov commented@joseph.olstad, what are these patches? I'd like to improve my projects also. :)
Comment #19
joelpittetIf you haven't seen this wiki it may be fun.
https://groups.drupal.org/node/210683
Comment #20
maximpodorov commentedThank you.
Comment #21
dillix commentedI'm also waiting for this being committed. My projects got performance and works well with this patch about a week.
Comment #22
joseph.olstadComment #23
japerryThanks everyone on this! Fixed.