Needs review
Project:
jPlayer
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
21 Dec 2014 at 02:37 UTC
Updated:
23 Dec 2014 at 06:11 UTC
Jump to comment: Most recent, Most recent file
Making changes to the css is hard. At least it was. I have added a field to the jPlayer admin settings (admin/config/media/jplayer) which allows people to customize where the jplayer.css resides. Yes. No more modifying the jplayer module file structure. The caveat is that the file MUST be called jplayer.css. I am adding the patch here for your reviewing pleasure, but I have tested and am pretty happy with the results and will most likely push it by the end of the weekend.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | jplayer-css_location-2396683-6.patch | 0 bytes | markie |
| #4 | jplayer-css_location-2396683-3.patch | 2.61 KB | markie |
| #1 | jplayer-css_location-2396683-1.patch | 1.97 KB | markie |
Comments
Comment #1
markie commentedPatch as promised.
Comment #2
damienmckennaComment #3
damienmckennaA quick suggestion - the if() statement should check if $varpath is empty, i.e. if (!empty($varpath)) {}.
Also, it needs a line added to hook_uninstall() for the new variable.
Comment #4
markie commented@DamienMcKenna: thanks a ton for quickly looking at this. I added the empty check and added a variable_del() for ALL the variables in the admin form, just for consistency. Please give it another go.
Comment #5
damienmckennaBetter. The only thing I'll mention is that the variable_get() calls don't need the second argument of NULL or an empty string because the default is NULL, which will satisfy both uses.
Comment #6
markie commented@DamienMcKenna thanks again for your quick comments. New patch submitted for your approval.
Comment #7
damienmckenna@markie: The patch was empty ;)