Take a little tour on our demo live sites :

Comments

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

JulienF’s picture

JulienF commented
Status: Needs review » Needs work

Hello,

Thanks for your contribution, here is my review:

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: Does not cause module duplication and/or fragmentation.

Master Branch
No: Are you sure you have a 6, 7 and 8 version ?

Licensing
No: Please check https://www.drupal.org/licensing/faq

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the readme template guidelines.

Code long/complex enough for review
No: check https://groups.drupal.org/node/195848

Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
I've identified that you are not using Drupal concepts all the time but I guess its better to fix the other issues first before digging into that.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Needs review

What is the licensing problem? Looks like you have not found any application blockers, should this be RTBC instead?

jim.applebee’s picture

jim.applebee commented
Status: Needs review » Needs work

Manual Review

Code long/complex enough for review
No: Module does not employ enough hooks and complexity is far too less. Please add more hooks to make this module confirm to drupal coding standards for basic functionality like libraries integration.
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) Fatal error: require_once(): Failed opening required 'loader/JsLink/JsLink.inc' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/modules_export/drupal/sites/all/libraries/wjs/wjs.inc on line 11
  2. (+) Please use hook_libraries to define libraries instead of directly including them
  3. (+) Please use hook_requirements to check if the libraries exist
weeger’s picture

weeger commented
Status: Needs work » Needs review
  • Added custom configuration hooks and hook_requirements for library checks
  • Removed the empty 8.x branch
  • I used Library API 2 for core php file on D7, but since the aim of this module is to generate dynamic list of javascripts / css links, it is not possible to use it for js and css. Demo http://drupal6.wexample.com
  • Can you tell me what is exactly the licencing problem ?

Thank you

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxweeger2393707git

I'm a robot and this is an automated message from Project Applications Scraper.

weeger’s picture

weeger commented

Fixed.

weeger’s picture

weeger commented
Status: Needs work » Needs review
weeger’s picture

weeger commented
Issue summary: View changes
abhiklpm’s picture

abhiklpm commented
Issue summary: View changes
Status: Needs review » Needs work

The demo site links you have given are not working, please fix them or remove them.

weeger’s picture

weeger commented
Status: Needs work » Needs review

My site was one day offline for six month, it was yesterday.

I suppose that if I put it online now someone will probably review this issue in... maybe.. one year or two, maybe ten ?

And maybe to point another detail or non relevant issue about this work ?

This is the second time I submit a project, and I've always waited more than six months to receive rejection from people who not took the time to understand what my module do. I place all my heart, my time and my energy into this projects, I work every day on it, from years, I made logo, illustration, I communicate, I post on networks, on blogs, forums, I improve it, I follow recommendations, I make adapters, for Drupal 6, for Drupal 7, for Git, for Composer, etc... and I'm still alone with rejections a silly reviews.

Today I'm deeply pained, depressed, tired.

The Drupal community, like a lot of other web community is hypocritically friendly. It's just NOT a community, but only a protectionist brotherhood. So thank you to consider this post as a SPAM, I let one of the "benevolent" administrator to remove all this issue. And please, stop pretending to be nice or interested by each other, I just will be surprised if someone takes consideration to this post.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

Git clone command for the sandbox is missing in the issue summary, please add it.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.