Incorrect arguments in form validate function?

Interesting typos, for sure. Since the email_registration_user_login_validate function doesn't use the $element nor $form arguments it seems that never caused a bug/confusion, but now they should be changed to match the spec.

Regarding 'mail' vs. 'email' I think it might be a feature that this is in 'email' as it is different than core on purpose. Is there a case where this caused some kind of bug or does it just make sense to you?

D8 affected the same

1. +++ b/email_registration.module
   @@ -191,7 +191,7 @@ function email_registration_form_user_admin_settings_submit($form, &$form_state)
   -function email_registration_user_login_validate($form, &$form_state) {
   +function email_registration_user_login_validate($element, &$form_state, $form) {
   

   ++ on this change

2. +++ b/email_registration.module
   @@ -203,7 +203,10 @@ function email_registration_user_login_validate($form, &$form_state) {
   +    $form_state['values']['mail'] = $form_state['values']['name'];
   

   also not sure about this change because it maybe incompatible with some other contrib

Not sure how that works now but email_registration_user_login_validate() is element validator

Marking as needs work to remove the change about email vs. mail.

@andypost why do you mark this as major? What's the impact of it?

@greggles I marked major because I can't get how it wotks now because form vs element valudators very different set of arguments

OK, here's a reroll of just the function signature without the email/mail change. That should go into a new issue/patch for discussion.

Fixing my credit.

	Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including: Triage issues and adding more context to existing issues. Flagging Email Registration as a favorite on the project page to help others discover it and show your support.

Drupal 7 is End of Life. We recommend upgrading to a supported version of Drupal.