Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #1164784: “Triptych” term is not widely understood; add "Featured top" and "Featured bottom"
Problem/Motivation
The Bartik theme adds classes to the body tag when some regions are filled, but then the same classes are not used in CSS for anything.
Proposed resolution
Remove code that sets the unnecessary classes. (Or, use them for something?)
Remaining tasks
Check that the classes are not really used for anything.
Remove the code that sets the classes.
Write a patch.
Review the patch.
Add screenshots to show patch does not break anything visually.
User interface changes
API changes
Original report by jeff-burnz
Beta phase evaluation
| Issue category | Task because we are cleaning up markup to remove redundant things. |
|---|---|
| Issue priority | Not critical because it is code cleanup |
| Unfrozen changes | Unfrozen because it only changes classes in the markup made available to CSS and the CSS is not using them. |
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | before.png | 76.48 KB | emma.maria |
| #5 | after.png | 75.25 KB | emma.maria |
| #5 | 768_before_after.jpg | 835.21 KB | emma.maria |
| #5 | 1400px_before_after.jpg | 1.38 MB | emma.maria |
| #5 | 400_before_after.jpg | 792.47 KB | emma.maria |
Comments
Comment #1
vermario CreditAttribution: vermario commentedComment #2
vermario CreditAttribution: vermario commentedThis patch removes the code in bartik.theme that sets the classes.
Comment #3
vermario CreditAttribution: vermario commentedComment #4
ruscoe CreditAttribution: ruscoe commentedLooks good. I couldn't find any use of either class (triptych or footer-columns) in the theme or CSS files that isn't the single use removed by this patch.
Pre and post-patch screenshots attached. No noticeable changes.
Comment #5
emma.mariaI added content to all of the triptych and footer regions as classes are only added currently when those regions contain content and compared before and after the patch.
Markup before...
Markup after....
@1400px before and after...
@768px before and after...
@400px before and after...
As before and after screenshots look the same and the classes are gone when the patch is applied this is a good piece of work, RTBC.
I also updated issue title to exclude non relevant content + added beta evaluation.
Comment #6
webchickVery nice catch, and thanks for the very thorough reviews as well!
Committed and pushed to 8.0.x. Thanks!