Follow-up to #1164784: “Triptych” term is not widely understood; add "Featured top" and "Featured bottom"

Problem/Motivation

The Bartik theme adds classes to the body tag when some regions are filled, but then the same classes are not used in CSS for anything.

Proposed resolution

Remove code that sets the unnecessary classes. (Or, use them for something?)

Remaining tasks

Check that the classes are not really used for anything.
Remove the code that sets the classes.
Write a patch.
Review the patch.
Add screenshots to show patch does not break anything visually.

User interface changes

API changes

Original report by jeff-burnz

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because we are cleaning up markup to remove redundant things.
Issue priority Not critical because it is code cleanup
Unfrozen changes Unfrozen because it only changes classes in the markup made available to CSS and the CSS is not using them.
CommentFileSizeAuthor
#5 before.png76.48 KBemma.maria
#5 after.png75.25 KBemma.maria
#5 768_before_after.jpg835.21 KBemma.maria
#5 1400px_before_after.jpg1.38 MBemma.maria
#5 400_before_after.jpg792.47 KBemma.maria
#4 2392361-post-patch.png190.77 KBruscoe
#4 2392361-pre-patch.png192.1 KBruscoe
#2 bartik_theme-2392361-2.patch844 bytesvermario

Comments

vermario’s picture

vermario commented
Title: Bartik theme: “Triptych” (Soon "Tertiary") classes added to body but never used in CSS » Bartik theme: “triptych” (Soon "tertiary") and footer-columns classes added to body but never used in CSS
Issue tags: -UMN 2011
vermario’s picture

vermario commented
Status: Active » Needs review
StatusFileSize
new bartik_theme-2392361-2.patch844 bytes

This patch removes the code in bartik.theme that sets the classes.

vermario’s picture

vermario commented
Issue summary: View changes
ruscoe’s picture

ruscoe commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2392361-pre-patch.png192.1 KB
new 2392361-post-patch.png190.77 KB

Looks good. I couldn't find any use of either class (triptych or footer-columns) in the theme or CSS files that isn't the single use removed by this patch.

Pre and post-patch screenshots attached. No noticeable changes.

emma.maria’s picture

emma.maria
she/her
commented
Title: Bartik theme: “triptych” (Soon "tertiary") and footer-columns classes added to body but never used in CSS » Bartik theme: “triptych” and footer-columns classes added to body but never used in CSS
Issue summary: View changes
Issue tags: -Needs manual testing
StatusFileSize
new 400_before_after.jpg792.47 KB
new 1400px_before_after.jpg1.38 MB
new 768_before_after.jpg835.21 KB
new after.png75.25 KB
new before.png76.48 KB

I added content to all of the triptych and footer regions as classes are only added currently when those regions contain content and compared before and after the patch.

Markup before...

Markup after....

@1400px before and after...

@768px before and after...

@400px before and after...

As before and after screenshots look the same and the classes are gone when the patch is applied this is a good piece of work, RTBC.

I also updated issue title to exclude non relevant content + added beta evaluation.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Very nice catch, and thanks for the very thorough reviews as well!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 31f3b0e on 8.0.x 
    Issue #2392361 by emma.maria, ruscoe, vermario: Bartik theme: “triptych...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.