Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Other tags
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
9 Dec 2014 at 15:19 UTC
Updated:
21 Aug 2016 at 17:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaIf you check the HTML5 spec it's completely valid:
What validator are you using?
Comment #2
Anonymous (not verified) commentedThe one from W3C. Maybe i am doing it wrong:
http://validator.w3.org/check?uri=reg.io%2Fc%2F52%2Ftalhof&charset=%28de...
Comment #3
damienmckennaYes, and another HTML5 validator also shows the same:
https://html5.validator.nu/?doc=http%3A%2F%2Freg.io%2Fc%2F52%2Ftalhof
Darn :-\
Comment #4
Anonymous (not verified) commentedFrom what i've found here it seems like itemprop is not supposed to be in head after all: http://html5doctor.com/microdata
The example states something like this:
Did not know you can use meta like this and the website even states some browser don't know this too. Pretty confusing.
Comment #5
rpayanmYou can check this
http://stackoverflow.com/questions/29123445/validation-error-the-itempro...
Comment #6
scor commentedCould someone post the HTML markup that is generated and that is not validating? (ideally a full page src please)
Comment #7
rpayanmHere the code:
Comment #8
tunaman commented@rpayanm It seems to originate from the Google+ sub module, disabling it removes those tags. Nobody uses Google+ anyway right?
Comment #9
capogeannis commentedUsed for better search result listings, better nav interface in those results for mobile, etc:
https://developers.google.com/structured-data/site-name
https://developers.google.com/structured-data/rich-snippets/products
Comment #10
michee.lengronneIn fact the itemtype is not set in the html tag. The patch above solves the issue. Your html template needs to be modified.
Comment #11
michee.lengronneThis patch is better as it takes the schemaorg module into account.
Comment #12
damienmckenna@michee.lengronne: Thanks, I'll test out your patches in the next few days.
Please don't forget to update the issue status to "needs review" when you upload a patch, that'll kick off testbot and let others know there's something to review.
Comment #14
scor commentedThe markup should be independent of whether the schema.org exists because the schema.org module outputs a different markup (RDFa) than what's being added in this patch (microdata). Patch #10 is the way to go.
Comment #15
michee.lengronneRight. I just saw that after the patch submitted.
Comment #17
michee.lengronneResubmitting
Comment #18
michee.lengronneNow.
Comment #20
damienmckenna@michee.lengronne: You need to check that the variable exists before appending to it.
Comment #21
michee.lengronneRight.
Comment #22
michee.lengronnethere
Comment #23
createchlondon commentedPlease may I ask what's happening with this fix? The issue with the Google+ meta tags is that it's adding a element. According to Google it should be Your WebSite Name so what is the point of this meta tag?
If it's going to be meta itemprop instead of title itemprop then it needs to be a child element of an itemscope. Please can we elevate this issue for a fix as it's causing problems with accessibility error testing.
Comment #24
damienmckennaUpdated to clean up the installation instructions, README.txt, etc.
Comment #25
damienmckennaCommitted. Thanks everyone!