Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
As of Services 7.x-3.6, a separate request is not needed to get the CSRF token. It is provided by the /user/login endpoint. Ref. #2115579: How about return token in user login service? and this commit.
Here's a backwards compatible patch that should make deployments to sites on Services 7.x-3.6 or newer quicker!
Comment | File | Size | Author |
---|---|---|---|
#6 | deploy-crsf-token-2388119-6.patch | 3.91 KB | reevo |
#2 | interdiff.txt | 870 bytes | star-szr |
#2 | deploy-2388119-2.patch | 4 KB | star-szr |
#1 | deploy-2388119-1.patch | 3.73 KB | star-szr |
Comments
Comment #1
star-szrFixing typo, attaching patch :)
Dreditor is going to make the changes look like a lot but really there are only ~8 lines of code changing if you ignore whitespace, I would recommend
git diff -w
or a visual difftool that can ignore whitespace for reviewing the changes.Comment #2
star-szrAnd if you don't object, this typo can be fixed as well, hehe.
Comment #3
star-szrFixing my typo in the issue summary as well.
Comment #4
star-szrAdding a potentially related issue, since this could solve a bug reported there where the destination site is being hosted from a subdirectory.
Comment #5
star-szrAfter a few days of testing, I can say that this patch is making my deployments actually quite noticeably faster.
Comment #6
reevo CreditAttribution: reevo at Viacom International Media Networks commentedRe-rolling the above patch for current 7.x-2.x-dev
Comment #7
star-szrThanks @reevo, from another Reeves :)
That patch should work the same as #1, it just doesn't have the typo fix. But that could be argued as out of scope.
Comment #9
skwashd CreditAttribution: skwashd at Dave Hall Consulting for Pfizer, Inc. commentedThanks for your work on this. I've merged the patch.