We should upgrade PHPUnit to the latest stable version (currently 4.4.2).

Currently we are stuck on an old branch of PHPUnit (4.1.x) because we have some tests that are using methods that are deprecated in PHPUnit 4.2: assertSelectEquals(), assertTag() and assertNotTag(). Once these deprecated methods are removed in #2331685: PHPUnit deprecated assertTag(), assertNotTag() and assertSelectEquals() we can update PHPUnit to the latest stable version.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Prioritized changes It is an external PHP library update
CommentFileSizeAuthor
#7 2387027-7-phpunit-4.4.2.patch1.06 MBpfrenssen
#7 2387027-7-phpunit-4.4.2-do-not-test.patch5.72 KBpfrenssen
#5 2387027-phpunit.patch505.4 KBkim.pepper
#5 2387027-phpunit-5-do-not-test.patch2.85 KBkim.pepper

Comments

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Major
catch’s picture

catch
he/him
Primary language English
commented
Parent issue: » #2400407: [meta] Ensure vendor (PHP) libraries are on latest stable release
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Issue summary: View changes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Postponed » Active
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
StatusFileSize
new 2387027-phpunit-5-do-not-test.patch2.85 KB
new 2387027-phpunit.patch505.4 KB

Ran composer update phpunit/phpunit

Status: Needs review » Needs work

The last submitted patch, 5: 2387027-phpunit.patch, failed testing.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs work » Needs review
StatusFileSize
new 2387027-7-phpunit-4.4.2-do-not-test.patch5.72 KB
new 2387027-7-phpunit-4.4.2.patch1.06 MB
aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Looks good to me...

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Issue summary: View changes

Added beta evaluation.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

No changes outside of composer and core/vendor/ so this looks good.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed a3fd4d0 on 8.0.x 
    Issue #2387027 by kim.pepper, pfrenssen: Upgrade PHPUnit to the latest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.