Remove taxonomy_select_nodes function

Needs a change notice first, but then RTBC

hot dog!

This change is explicitly allowed in https://www.drupal.org/contribute/core/beta-changes, and searching the change listings for "taxonomy_select_nodes" brings up https://www.drupal.org/node/2084727 so we're good to go on the change record.

However, there's one other instance of this function after the patch:

/**
 * @defgroup taxonomy_index Taxonomy indexing
 * @{
 * Functions to maintain taxonomy indexing.
 *
 * Taxonomy uses default field storage to store canonical relationships
 * between terms and fieldable entities. However its most common use case
 * requires listing all content associated with a term or group of terms
 * sorted by creation date. To avoid slow queries due to joining across
 * multiple node and field tables with various conditions and order by criteria,
 * we maintain a denormalized table with all relationships between terms,
 * published nodes and common sort criteria such as sticky and created.
 * This is used as a lookup table by taxonomy_select_nodes(). When using other
 * field storage engines or alternative methods of denormalizing this data
 * you should set the taxonomy.settings:maintain_index_table to '0' to avoid
 * unnecessary writes in SQL.
 */

Those docs in taxonomy.module need to be updated.

This change is not unfrozen - but removing dead, untested code is prioritised so is allowed. We should have an additional change record detailing the removal of this function as contrib might be relying on it.

Sorry I was wrong in #6 - the existing CR is enough.

Committed 0a301aa and pushed to 8.0.x. Thanks!

Thanks for adding the beat evaluation to the issue summary.

The change notice mentioned in #7 either doesn't exist, or is unpublished (I get a 404).