$element['#ajax']['callback'] is broken, hence breaking e.g. inserting images in CKEditor

We have some pseudo-ajax tests, how did they not catch this?

We have some pseudo-ajax tests, how did they not catch this?

+1 :(

And thanks, @jbrown, for catching this so fast!

This also broke all editor.module dialogs. Hence it's now impossible to add links or images in CKEditor.

The patch in the IS can not possibly ever have applied. I wonder against which version it was rolled.

I wanted to write a test, but I don't think we actually can. That's the thing about #ajax: it is triggered by JS. We cannot emulate that, for the logic to construct the /system/ajax/SOMETHING URL lives in JS.
The best we can do, is to verify the AJAX settings. This patch adds test coverage for that.

+++ b/core/modules/system/tests/modules/ajax_test/src/Form/AjaxTestForm.php
@@ -51,4 +65,8 @@ public function submitForm(array &$form, FormStateInterface $form_state) {}
+  public function preview(array &$form, FormStateInterface $form_state) {
+    return new Response('#ajax-triggered submit worked!');
+  }

I'm a bit confused as this does not have an assertion

#8: You're right; I added that and then realized I could only manually trigger that, and hence that'd be pointless. I can just remove that hunk.

#2384327: admin/config/development/configuration/single/export doesn't allow you to export a single configuration. is a duplicate of this, closed it.

just a gentle plug for #2232861: Create BrowserTestBase for web-testing on top of Mink
we *need* front-end testing, please review :)

I just ran into this. #7 fixes the issue.

Marked #2385599: "Add new view" AJAX returns the entire form as a dup of this bug. The patch in #7 fixes that issue.

This reroll addresses #8, and adds a comment explaining why we can't test it (basically what I wrote in #7).

Anybody want to RTBC this patch and make many UIs across Drupal 8 work again? :)

I think the added test coverage is sufficient for what we can test. The explanation is a bit verbose on the ::preview but I see where it confused @dawehner originally. Looks good :)

This issue addresses a critical bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 1193f67 and pushed to 8.0.x. Thanks!

diff --git a/core/modules/system/src/Tests/Ajax/DialogTest.php b/core/modules/system/src/Tests/Ajax/DialogTest.php
index 2ac88e1..cbb7093 100644
--- a/core/modules/system/src/Tests/Ajax/DialogTest.php
+++ b/core/modules/system/src/Tests/Ajax/DialogTest.php
@@ -6,7 +6,7 @@
  */
 
 namespace Drupal\system\Tests\Ajax;
-use Drupal\Core\Ajax\SettingsCommand;
+
 use Drupal\Core\Url;
 
 /**

Fixed on commit - SettingsCommand was not used.