Follow-up to #1510544: Allow to preview content in an actual live environment
Problem/Motivation
The 'theming' styling for the node preview bar is within Bartik's style.css. This includes the background colour. If the user is using a theme that is not Bartik then there is no background styles and it's hard to read the UI elements within the bar.
This feel inconsistent with the toolbar, which has it's own styling regardless of theme.
Proposed resolution
Move the styling in the node modules node.preview.css file.
Remaining tasks
User interface changes
A useable node preview bar in all themes
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#2 | node-preview-bar-2384169-2.patch | 3.12 KB | ricovandevin |
Screen Shot 2014-11-29 at 12.53.37.jpg | 450.36 KB | LewisNyman |
Comments
Comment #1
ricovandevin CreditAttribution: ricovandevin commentedI'll work on this issue.
Comment #2
ricovandevin CreditAttribution: ricovandevin commentedCSS moved to node.preview.css.
Maybe colors should be neutral? I'm not a themer so if someone else can have a look at that...
Comment #3
ricovandevin CreditAttribution: ricovandevin commentedComment #4
LewisNymanI think we're better off just keeping the colours as they are, and just moving the CSS. Also see: #2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs
Comment #5
ricovandevin CreditAttribution: ricovandevin commentedI'll re-roll the patch once #2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs is committed.
Comment #6
manningpete CreditAttribution: manningpete commentedRemoving the novice tag.
Why: because issue is postponed. People new to the issue queue might search for just the Novice tag and not know to filter to active issues. Also, looks like this issue has been addressed already, just waiting for another issue to be committed.
Novice tag documentation: https://www.drupal.org/core-mentoring/novice-tasks
Comment #7
LewisNymanClosing as a duplicate and merging with #2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs. See comment: https://www.drupal.org/node/2341221#comment-9909719