Follow-up to #1510544: Allow to preview content in an actual live environment

Problem/Motivation

The 'theming' styling for the node preview bar is within Bartik's style.css. This includes the background colour. If the user is using a theme that is not Bartik then there is no background styles and it's hard to read the UI elements within the bar.

This feel inconsistent with the toolbar, which has it's own styling regardless of theme.

Proposed resolution

Move the styling in the node modules node.preview.css file.

Remaining tasks

  • Move the CSS
  • Test

    • User interface changes

    A useable node preview bar in all themes

    API changes

    None

    CommentFileSizeAuthor
    #2 node-preview-bar-2384169-2.patch3.12 KBricovandevin
    Screen Shot 2014-11-29 at 12.53.37.jpg450.36 KBLewisNyman
    Support from Acquia helps fund testing for Drupal Acquia logo

    Comments

    ricovandevin’s picture

    ricovandevin CreditAttribution: ricovandevin commented
    Assigned: Unassigned » ricovandevin

    I'll work on this issue.

    ricovandevin’s picture

    ricovandevin CreditAttribution: ricovandevin commented
    FileSize
    node-preview-bar-2384169-2.patch3.12 KB

    CSS moved to node.preview.css.

    Maybe colors should be neutral? I'm not a themer so if someone else can have a look at that...

    ricovandevin’s picture

    ricovandevin CreditAttribution: ricovandevin commented
    Status: Active » Needs review
    LewisNyman’s picture

    LewisNyman
    he/him
    CreditAttribution: LewisNyman commented
    Related issues: +#2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs

    I think we're better off just keeping the colours as they are, and just moving the CSS. Also see: #2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs

    ricovandevin’s picture

    ricovandevin CreditAttribution: ricovandevin commented
    Status: Needs review » Postponed

    I'll re-roll the patch once #2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs is committed.

    manningpete’s picture

    manningpete CreditAttribution: manningpete commented
    Issue tags: -Novice

    Removing the novice tag.

    Why: because issue is postponed. People new to the issue queue might search for just the Novice tag and not know to filter to active issues. Also, looks like this issue has been addressed already, just waiting for another issue to be committed.

    Novice tag documentation: https://www.drupal.org/core-mentoring/novice-tasks

    LewisNyman’s picture

    LewisNyman
    he/him
    CreditAttribution: LewisNyman at Wunder commented
    Status: Postponed » Closed (duplicate)

    Closing as a duplicate and merging with #2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs. See comment: https://www.drupal.org/node/2341221#comment-9909719