Options element stopped working

This was broken by #2117593: Select with empty (pre-built) option list should not be shown

Dirty webform patch that essentially revert the webform commit. Now formbuilder works as expected.

Work for me as well. But this is a patch for Webform, should it be fixed there? ...or maybe there is something that can be done from Form Builder? ..ie. why is FB adding an empty list when drag'n'drop is being used?

Got a way to fix the issue within Form Builder itself.

Fixed patch format.

markus_petrux, thanks for creating the patch.

I wasn't able to apply the patch in #6 - I got the error "form_builder/modules/webform/form_builder_webform.components.inc: No such file or directory". It looks like the patch in #6 was created from outside the form_builder directory.

I've re-rolled the patch from the form_builder directory, so the only difference is the path of the file to modify.

I've tested the above patch and it seems to be working as expected.

Patch #7 works like a charm :-)
Thank you all!

I think this patch is a workaround for a deeper lying problem: The defaults are rendered using webform and the resulting renderable arrays are messed with.

So I'd suggest to pass the additional items and default value as $merge_extras parameter _form_builder_webform() instead. Then the component's render function should give us some reasonable output.

This issue has another aspect though: We really should display some placeholder if the webform component doesn't yield any output.

This looks major bug to me

I agree with to change to Major the status (please note that the Form Builder 7.x-1.6 includes a security update).

Patch #7 fixes the UI so form builder is usable again. Cool, thanks!

However every new component you add makes a strict warning in Drupal log like this:

Strict warning: Only variables should be passed by reference in _form_builder_add_element() (line 121 of …/sites/all/modules/contrib/form_builder/includes/form_builder.admin.inc).

The strict error I think was just due to trying to call too many functions on one line. I assigned drupal_get_form to a $form variable on a separate line and that fixed the watchdog error for me.

So let's take this one step at a time. Here is a patch that transforms the default select-boxes to use the extra-array instead of messing with the renderables.

@drupalninja99 I've already commited the fix for the strict warning into 7.x-1.x.

@torotil

Do I just need to apply the "form_builder-options_element_hidden-2383285-15" patch to fix the options element issue?

@ucscholar: just #15 should be fine.