Of course 'and' works but as it has a different precedence order than '&&" this could create unexpected issues if left as is. It's a small clean up change, and shouldn't have other side effects.

See http://php.net/manual/en/language.operators.php for more on this.

Patch coming up.

CommentFileSizeAuthor
#4 2381491-CKEditorPluginManager-3.patch1.15 KBkattekrab
#1 2381491-CKEditor-1.txt1.15 KBkattekrab

Comments

kattekrab’s picture

kattekrab commented
StatusFileSize
new 2381491-CKEditor-1.txt1.15 KB

And here's the patch

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Of course 'and' works but as it has a different precedence order than '&&" this could create unexpected issues if left as is.

OH PHP!!

kattekrab’s picture

kattekrab commented
StatusFileSize
new 2381491-CKEditorPluginManager-3.patch1.15 KB

Renamed file

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I really wonder how I managed to do this. I did this at #2089631-9: Showing/hiding of CKEditor plugin settings is fragile, automate it (breaks in narrow viewports and when enabling CKEditor).

Wim--

dries’s picture

dries commented
Category: Bug report » Task
Priority: Normal » Minor
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This is the only instance of this in Drupal core - makes sense to remove it. Let's be consistent and this will not disrupt anything. Committed 2f35d45 and pushed to 8.0.x. Thanks!

  • alexpott committed 2f35d45 on 8.0.x 
    Issue #2381491 by kattekrab: Change "and" to && in CKEditorPluginManager
kattekrab’s picture

kattekrab commented

W00t! Thanks Alex :-)

D.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.