Improve example.gitignore

Well, I would argue that you maybe actually want to have some of those in GIT, especially if you have production files, you want to track as well.
Excluding all of them by default is maybe a little bit too much, to be honest.

Maybe we could explicit allow example.*services*.yml and example.*settings*.yml which itself is an example what you want to have in your repo?

Let's get it in.

+++ b/example.gitignore
@@ -26,7 +26,8 @@ sites/simpletest
+# */*services*.php

s/php/yml/ … or am I mistaken?

Lovely :)

Isn't a problem with this that (for example) default.settings.php is in git?

I think it should be better to specify that the default.settings.php is in git.
I've add new lines in example.gitignore for this.

Looks good a bit confusing based on the title which the patch addresses but doesn't but does:)

+++ b/example.gitignore
@@ -26,7 +27,9 @@ sites/simpletest
+# !*/default.settings.php
+# */*services*.yml

Let's do the same for default.services.yml as we've done for default.settings.php

default.services.yml, not default.services.php.

Did we forget development.services.yml? I have it in sites/development.services.yml... or should I move it into sites/default?

Hi

I have kept development.services.yml in sites folder as it is in drupal 8.1.x.

Just added the path sites/development.services.yml in git ignore. I had just given a try.

Please review.

Thanks!!

Rerolled patch on #22 (i think that patch on #25 is not ok, maybe with this you can make the change, i don't know).

This still doesn't address #24.

whether we have or not to move the development.services.yml to site/default the default place of that file is /sites/ and IMO we should ignore it there by default.

Let's see if this can push this forward.

+++ b/example.gitignore
@@ -29,7 +31,10 @@ sites/simpletest
+# **/*services*.yml

Wouldn't this line here ignore modules' services.yml files in a multisite configuration?

Yup, you are right. that line is even going to ignore /sites/default/services.yml file :-|

We need add an extra line there with something like:

!sites/*/services.yml

Thanks for your review, this definitely needs work.

Updated patch.

Hi sidharthap.

Thanks for your patch, when a new patch is uploaded is necessary provide the interdiff as well.

Can you please upload it?

Thanks!

I'm confuse.

Initially I thougth to we wanted to ignore all the files but settings.php and services.yml but it seems to I was wrong, we wanted to ignore all of them but example.settings.php and example.services.yml?

If that is the case then: 32 is correct.

It seems that this issue title and summary doesn't match. Please update the title and summary to explain what this issue has evolved into.

#37 is not applied not 10.x. version. no changes in patch just re-roll in 10.x.

#52 failed because only changing
/example.gitignore
will not work, patch will work after adding the same lines in
/core/assets/scaffold/files/example.gitignore

I am uploading updated patch for 10.1.x-dev with interdiff

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue under control, following Review a patch or merge request as a guide.

This appears to need an issue summary as there seem to be more changes then what's originally listed. Using the default template would be super helpful.

===========

Just FYI to help get the message out there.

Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.
To receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines for more information.

Thanks for your work on this issue.

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because it has a clear step to review the short MR.

Seems straight forward enough.

Why do we need ** for services and not for settings. And the recommendation for when .gitignore is inside sites is wrong.

Nothing about this has been quick.

Wouldn't it be more fruitful to focus on completing #3082958: Add gitignore(s) to Composer-ready project templates instead? It will place a .gitignore file in the project root automatically, upon creation via Composer.

Also, I believe multisite installations are such a rare occurrence, that perhaps it would fit better on a documentation page?

At either DrupalCon Vienna or Nara I told someone verbally this needed framework manager review, which somehow never made it back onto the issue, but looks like @alexpott found it anyway which is good.

I think #66 makes sense, but is also sort of implementation details. Regardless of where it goes, we need to agree on the contents. We could mark one or the other of these issues as duplicates or at least postponed on the other.

Also no longer in a novice status. Thanks!

Based on #67 I am going to postpone 'the other one', #3082958: Add gitignore(s) to Composer-ready project templates. Today, it seems better to make a small, incremental fixes.

I have applied the suggestions made by alexpott and rebased.

Rebased this one and from what I can tell all feedback has been addressed.

Committed and pushed 046e7595b88 to main and 59a2ce11bb3 to 11.x. Thanks!

Nice, glad to see this fixed!