Steps to reproduce bug

1. Install "hosting_tasks_extra" 6.x-2.1. Follow all instructions in its README.txt file. Install all requirements.
2. Click on "Sites"
3. Under "Site" column click on the link on the left side of "Hostmaster". Let's call this link "aegir.example.com"
4. Click on "Edit" tab
5. Under "HTTP Basic Authentication" fill the form. For details find attached screenshot.
6. Click on "Save" button
7. Wait for the Aegir queue to run.
8. After the queue is done. The Aegir log of a verify task for that site does not show something like "Passwords path /var/aegir/config/server_master/apache/passwords.d exists.". It seems the provision code is not active.
9. When visiting "aegir.example.com" the "HTTP Basic Authentication" pop up is not showing. Expected result is a pop should show asking for credentials. And anonymous users should not be able to access the site.

Possible causes
* "provision_tasks_extra" and "registry_rebuild" folders are not uploaded to the appropriate directory? Details below under "Things we tried that did not work" section.
* "hosting_tasks_extra" 6.x-2.1 does not support Aegir 2.1?
* "HTTP Basic Authentication (http_basic_auth)" does not work on Aegir itself / "hostmaster"? It works only on other sites created by Aegir?
* "registry_rebuild" version 7.x-2.2 does not support Drupal 6.x?

Using
* hosting_tasks_extra: 6.x-2.1
* provision_tasks_extra: 6.x-2.1
* registry_rebuild: 7.x-2.2
* Aegir: 2.1
* Drupal: 6.31
* Debian Server: 7.7 at 64 bit
* Apache
* Kernel: 3.16.5-x86_64
* MySQL database: 5.5.40
* PHP: 5.4.35-0+deb7u2
* PHP memory limit: 128M
* GD library: 2.0.36

Things we tried that did not work
* Reinstall a fresh Aegir 2.1
* Log-out aegir, then test
* drush cache-clear drush
* Clear all drupal caches
* Reboot server
* Tested from another computer with another IP. In case our IP was whitelist by "hosting_tasks_extra".
* Uploaded "provision_tasks_extra" and "registry_rebuild" folders in the following directories
** /var/aegir/.drush/
** /var/aegir/.drush/commands/
** /etc/drush/
** /usr/share/drush/commands/

CommentFileSizeAuthor
hosting_tasks_extra-2-1.png56.61 KBFrancewhoa
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented

This bug was confirm by milovan at http://community.aegirproject.org/discuss/htaccess-password-and-ip-prote...

Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented

Other things we tried. But they did not fix the bug.

Uploaded "provision_tasks_extra" and "registry_rebuild" folders in the following directories
* /var/aegir/.drush/
* /var/aegir/.drush/commands/
* /etc/drush/
* /usr/share/drush/commands/

Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented
Issue summary: View changes
Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented
Issue summary: View changes
Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented
Issue summary: View changes
Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented

Francewhoa, note to self: This is related to https://www.drupal.org/node/2005766

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Version: 6.x-2.1 » 7.x-3.x-dev
Assigned: Unassigned » ergonlogic

I can confirm that this isn't working in Aegir 3.x either. I'll see if I can't fix it there, then we can look at back-porting the fix.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented

So, first things first... We end up with some http_basic_auth fields in the site context, but they are NULL:

  'http_basic_auth_username' => NULL,
  'http_basic_auth_password' => NULL,
  'http_basic_auth_message' => NULL,

So my suspicion is that we're aren't passing these from the front-end properly.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented

BTW, I'm working on this in the 'http_basic_auth' branch that I forked off of 7.x-3.x

Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented

Thanks for investigating ergonlogic :) Backport sounds great.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Assigned: ergonlogic » Unassigned
Status: Active » Needs review

It looks like it was hosting_http_basic_auth_node_load() adding the fields incorrectly. AFAICT, this is now working in the 'http_basic_auth' branch.

helmo’s picture

helmo CreditAttribution: helmo commented
Status: Needs review » Reviewed & tested by the community

Looks good, I just tried the 'http_basic_auth' branch.

helmo’s picture

helmo CreditAttribution: helmo commented
Status: Reviewed & tested by the community » Fixed

merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented

Thanks ergonlogic and helmo :)

Francewhoa’s picture

Francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
CreditAttribution: Francewhoa commented

All, Done. I created a ticket about Back-port HTTP Basic Authentication fix from Aegir 3.x to 2.x at https://www.drupal.org/node/2449837
Any volunteers?

We're happy to contribute testing and documentation