Clean-up Comment module Test members - ensure property definition and use of camelCase naming convention

@tibbsa: See the update to the parent issue.

1. +++ b/core/modules/comment/src/Tests/CommentStatisticsTest.php
   @@ -16,12 +16,18 @@
   +   * A secnodary user for posting of comments. ¶
   

   There is a whitespace error and a mistype here. I would prefer 'A secondary user for posting comments.'.

2. +++ b/core/modules/comment/src/Tests/CommentTypeTest.php
   @@ -21,29 +21,10 @@
   -   * Admin user
   -   *
   -   * @var \Drupal\Core\Session\AccountInterface
   -   */
   -  protected $adminUser;
   -
   -  /**
   -   * Permissions to grant admin user.
   -   *
   -   * @var array
   -   */
   -  protected $permissions = array(
   -    'administer comments',
   -    'administer comment fields',
   -    'administer comment types',
   -  );
   -
   -  /**
   

   This adminUser is configured with different permissions than in the parent class, so I would not remove the overridden property in this class.

I found some more to be changed:

$ egrep -r '\$this\->[a-z]+_[a-z_]+' core/modules/comment/src/Tests/
core/modules/comment/src/Tests//Views/ArgumentUserUIDTest.php:        'nid' => $this->node_user_posted->id(),
core/modules/comment/src/Tests//Views/ArgumentUserUIDTest.php:        'nid' => $this->node_user_commented->id(),
core/modules/comment/src/Tests//Views/CommentFieldFilterTest.php:    $this->comment_titles = array(
core/modules/comment/src/Tests//Views/CommentFieldFilterTest.php:      'entity_id' => $this->node_user_commented->id(),
core/modules/comment/src/Tests//Views/CommentFieldFilterTest.php:    $this->comment->subject->value = $this->comment_titles['en'];
core/modules/comment/src/Tests//Views/CommentFieldFilterTest.php:    $this->comment->comment_body->value = $this->comment_titles['en'];
core/modules/comment/src/Tests//Views/CommentFieldFilterTest.php:      $translation->comment_body->value = $this->comment_titles[$langcode];
core/modules/comment/src/Tests//Views/CommentFieldFilterTest.php:      $translation->subject->value = $this->comment_titles[$langcode];
core/modules/comment/src/Tests//Views/CommentFieldFilterTest.php:      $this->assertEqual(substr_count($text, $this->comment_titles[$langcode]), 2 * $count, 'Translation ' . $langcode . ' has count ' . $count . ' with ' . $message);
core/modules/comment/src/Tests//Views/CommentTestBase.php:    $this->node_user_posted = $this->drupalCreateNode();
core/modules/comment/src/Tests//Views/CommentTestBase.php:    $this->node_user_commented = $this->drupalCreateNode(array('uid' => $this->account2->id()));
core/modules/comment/src/Tests//Views/CommentTestBase.php:      'entity_id' => $this->node_user_commented->id(),
core/modules/comment/src/Tests//Views/FilterUserUIDTest.php:        'nid' => $this->node_user_posted->id(),
core/modules/comment/src/Tests//Views/FilterUserUIDTest.php:        'nid' => $this->node_user_commented->id(),
core/modules/comment/src/Tests//Views/FilterUserUIDTest.php:    $this->column_map = array('nid' => 'nid');
core/modules/comment/src/Tests//Views/FilterUserUIDTest.php:    $this->assertIdenticalResultset($view, $result_set, $this->column_map);

It looks like CommentAttributesTest extends CommentTestBase, so you have to include that in this patch.

1. +++ b/core/modules/comment/src/Tests/CommentTypeTest.php
   @@ -19,7 +19,6 @@
   -
   

   There is usually a space after the class declaration, so don't remove it.

2. +++ b/core/modules/comment/src/Tests/Views/CommentTestBase.php
   @@ -27,7 +27,37 @@
   +   * A normal user (who can be the author of a node that $account will
   +   * comment upon).
   

   This comment must be on a single line. A full description can come after a full space.

3. +++ b/core/modules/comment/src/Tests/Views/CommentTestBase.php
   @@ -27,7 +27,37 @@
   +   * Stores a node posted by the user created as $account;
   

   The comment must end with a period, not a semicolon.

4. +++ b/core/modules/comment/src/Tests/Views/CommentTestBase.php
   @@ -27,7 +27,37 @@
   +   * Stores a node posted by the user created as $account2, upon which
   +   * the user created as $account will comment.
   

   Same thing - must be one line.

5. +++ b/core/modules/rdf/src/Tests/CommentAttributesTest.php
   @@ -19,6 +19,20 @@
   +   * URI of the test node created by CommentTestBase::setUp()
   

   This must end with a period.

@tibbsa: Again, great work.

Please do not change anything in the RDF file that is not strictly necessary so we can keep this issue in scope. I think all that is needed is webUser(?). Could you please update this issue summary and #2381921: Clean-up RDF module test members - ensure property definition and use of camelCase naming convention accordingly?

+++ b/core/modules/comment/src/Tests/CommentTranslationUITest.php
@@ -24,7 +24,14 @@ class CommentTranslationUITest extends ContentTranslationUITest {
   /**
-   * Modules to install.
+   * An administrative user with permission to administer comments.
+   *
+   * @var \Drupal\user\UserInterface
+   */
+  protected $adminUser;
+
+  /**
+   * Modules to enable.
    *
    * @var array
    */
@@ -143,8 +150,8 @@ protected function assertPublishedStatus() {

@@ -143,8 +150,8 @@ protected function assertPublishedStatus() {
    * Tests translate link on comment content admin page.
    */
   function testTranslateLinkCommentAdminPage() {
-    $this->admin_user = $this->drupalCreateUser(array_merge(parent::getTranslatorPermissions(), array('access administration pages', 'administer comments', 'skip comment approval')));
-    $this->drupalLogin($this->admin_user);
+    $this->adminUser = $this->drupalCreateUser(array_merge(parent::getTranslatorPermissions(), array('access administration pages', 'administer comments', 'skip comment approval')));
+    $this->drupalLogin($this->adminUser);

This changes were introduced during reroll

CommentCSSTest line 131 missed a camelCase:

        $expectedJS = ($case['user'] !== 'anonymous');
        $this->assertIdentical($expectedJS, isset($settings['ajaxPageState']['js']['core/modules/comment/js/comment-new-indicator.js']), 'drupal.comment-new-indicator library is present.');

CommentTranslationUITest line 24: No @var declaration.

$expectedJS is not a class property, so no need to camelCase it.

Yes, exactly. :-) It should be $expected_js.

Oh .. ha ha. That's correct. It's a little out-of-scope but we could fix it.

In that case.... Will RTBC if it passes green. :-)

The patch in #28 refactors class-level properties from under_score to camelCase as the coding standards demand.

I know this because I applied the patch, ran my own coding standards review with netbeansdrupalcomposed, and poked through all the test classes to find camel case and underscore violations. I found a few that were mentioned in #31, but those are apparently out of scope for this issue.

git ac https://www.drupal.org/files/issues/clean_up_comment_module-2380023-28.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 51330  100 51330    0     0   127k      0 --:--:-- --:--:-- --:--:--  129k
error: patch failed: core/modules/rdf/src/Tests/CommentAttributesTest.php:105
error: core/modules/rdf/src/Tests/CommentAttributesTest.php: patch does not apply

That is not in commnet module.

@alexpott: RDF CommentAttributesTest extends CommentTestBase

rerolled from #28

Re-up my RTBC from #28.

As noted above, this patch touches more than the comment module because other modules use comment's test base classes.

1. +++ b/core/modules/comment/src/Tests/CommentStatisticsTest.php
   @@ -16,12 +16,18 @@
    class CommentStatisticsTest extends CommentTestBase {
   +  /**
   

   Let's add a blank newline in between here.

2. +++ b/core/modules/comment/src/Tests/CommentTranslationUITest.php
   @@ -24,7 +24,14 @@ class CommentTranslationUITest extends ContentTranslationUITest {
   +   * Modules to enable.
   

   This should be "install".

Still applies, phpcs still tells me there are no underscore problems, and pulls in the changes from #45.

Committed 09b496e and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.