Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The RDF module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
Note: The references to $this->web_user in \Drupal\rdf\Tests\CommentAttributesTest have been corrected to $this->webUser as part of #2380023: Clean-up Comment module Test members - ensure property definition and use of camelCase naming convention, as this is derived from \Drupal\comment\Tests\CommentTestBase. If testing prior to the Comments patch being pulled into 8.0.x, expect a failure with this test.
Beta phase evaluation
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | rdf-testing-camelcase-2381921-4.patch | 13.17 KB | tibbsa |
| #4 | rdf-testing-camelcase-2381921-interdiff-2-4.txt | 6.54 KB | tibbsa |
Comments
Comment #1
tibbsa commentedComment #2
hussainwebIt is not complete due to dependencies to comment and simpletest module, which needs to be done there first. I believe there are already issues for that.
Comment #3
tibbsa commentedThere are other changes to make to CommentAttributesTest (addition of properties $baseUri, $nodeUri) which can be made in this issue. The references to $this->web_user will have to await the Comments module changes, and the references to $this->root_user will have to await Simpletest, but everything else can change here.
In TaxonomyAttributesTest, $this->vocabulary is not declared as a property prior to use.
Comment #4
tibbsa commentedFixing the comments from #3
Comment #6
mile23The patch in #4 refactors class-level properties from under_score to camelCase as the coding standards demand.
I know this because I applied the patch, ran my own coding standards review with netbeansdrupalcomposed, and poked through all the test classes to find camel case and underscore violations.
Comment #7
alexpottCommitted 07149c4 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.