Abstract
After Activation of Weblinks module, it's not possible to flag the "Sticky to Top" option for nodes (the checkflag is not saved).

Description

  1. The issue is very evident with Forum or Advanced Forum Modules, where "Sticky to Top" option should give a different Image, but with Weblinks module active, this is not happening correctly,
  2. while in Advanced Forum, all new topics Titles are flagged as "Sticky:", even they are not.
  3. Some times if user try to check "Sticky to Top" for some node, the node actually goes to the top of the list, but since the flag for "Sticky to Top" is not saved, after promoted, it's not possible to "uncheck" and demote the node from the Top list.
  4. This Bug affect both 7.x-1.x-ev. and 7.x-1.x-Alpha Versions

Testing Enviroment

  • After discovered this bug in the live site, we've made a huge troubleshoot and found that the cause is Weblinks
  • To be sure that the Issue is not caused by some conflict with other modules in the live site, we've also tested with Fresh Drupal installations
  • At the end both Standard Drupal Installation and minimal Drupal Installation(+Menu, Options, Taxonomy) were resulted affected by this bug.
  • The error occurs both in local Dev Site on Windows(running Xampp) and remote Linux Machine

Comments

jonathan1055’s picture

jonathan1055 commented
Component: Testing » Code
Issue tags: -sticky, -top, -Forum, -nodes, -content, -Stocky to Top, -advanced forum, -bug
Related issues: +#2148005: weblinks.weight.inc stores all contributions in sticky 100 and -100, +#2030765: Editing a sticky node sets db field to -100 for non-weblinks nodes. Do not encode weight and remove the weight.inc file

Hi francescosciamanna,
Thank you very much for the detailed description and your testing results. I think this has already been discussed in #2030765: Editing a sticky node sets db field to -100 for non-weblinks nodes. Do not encode weight and remove the weight.inc file and #2148005: weblinks.weight.inc stores all contributions in sticky 100 and -100. Yes, there definitely is a problem and we'll try to find a good solution for you.
Jonathan

gstegemann’s picture

gstegemann commented

Jonathan,

you're right. This issue is already known and was discussed in both mentioned issues.

@francescosciamanna: as a workaround I would suggest to install and enable the Weight Module which disables this behaviour.

Gerhard

francescosciamanna’s picture

francescosciamanna commented

@GStegemann
Thank you for suggestion, the Weight Module seems can solve my problem. But imho even this Issue is the same of the twos mentioned by Jonathan, the latter are not so easy to be found, or at least is not so evident the link between the effect(this topic), and the cause(the two old topics). My intention was only make a small contribution to the community, mostly for these with poor/almost nothing coding knowledge like me, hoping that can save a little of time, if encounter a similar situation.

@Jonathan
Thank you all(including GStegemann) for your efforts on maintain this module, I really hope you can solve this issue not for me, since Weight Module does the job well, but for anyone else that can run into this issue in the future: we have 60 modules installed in our site and no need of Sticky option until we decided to open the Forum Section, fortunately I have personally some Troubleshoot experience that helped us to avoid one by one exclusion, in that scenario Weblinks is one of the last module to be tested and disabled in our test list both in installation-reverse-chronological and alphabetical order!

Cheers,
Francesco

jonathan1055’s picture

jonathan1055 commented

Hi Francesco,
Thank you for your report and careful testing. Sorry you had all that trouble.
On #2030765: Editing a sticky node sets db field to -100 for non-weblinks nodes. Do not encode weight and remove the weight.inc file I have made a patch to solve this problem. Is it possible for you to test it?
Jonathan

francescosciamanna’s picture

francescosciamanna commented

With pleasure Jonathan, I'll test it within tomorrow (patch already downloaded). BR, Francesco

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review

Thank you. I have uploaded a newer patch file which also includes an update function to fix any bad values - see comment #14 in the other issue.

jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Active

Setting this issue back to 'active', sorry it should not be 'needs review' as there is no patch here, only on #2030765: Editing a sticky node sets db field to -100 for non-weblinks nodes. Do not encode weight and remove the weight.inc file. Simpler if we keep just one issue to review.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Fixed

Fixed via #2030765: Editing a sticky node sets db field to -100 for non-weblinks nodes. Do not encode weight and remove the weight.inc file. See commit 5b1a7e4 for details.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.