Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
system.module
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
8 Nov 2014 at 15:04 UTC
Updated:
27 Nov 2014 at 07:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerJust tagging it.
Comment #2
podarokYup
Here is a patch.
Figuring out where test for this function should be located.
Comment #3
podarokComment #4
podarokadded tests
Comment #5
podarokUploading tests only . Should fail.
Comment #7
podaroknice
#4 contains fix and tests. Needs review
Comment #8
m1r1k commented#4 looks good
Comment #9
andypostI'd prefer to see here a
DrupalSetMessageTestconverted toKernelTestBaseintegration tests already all over core within UI (form) tests
Comment #10
tim.plunkettI don't see how this unset is necessary. The important change is from $message to $new in the !in_array check.
Comment #11
alexpottYep this is unnecessary
Comment #12
podarokLet's not mix bug fixing with code refactoring. If it is necessary - do that in follow-up
Here is a new patch.
Removed unset.
Comment #13
podarokremoved tag
Comment #14
andypostComment #15
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 7473eaf and pushed to 8.0.x. Thanks!