Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
panels_renderer_editor->ajax_style_type() calls ctools_content_get_subtype() and provides a pane id. But FPP and og_fpp (correctly) filter out all non-reusable panes in their content_types callback. This results in undefined index errors for non-reusable FPPs when editing their styles.
This is a Panels issue, primarily because of an architectural issue with Panels. It seems that the content_types callback is intended to filter for allowed types. See panels_common_get_allowed_types(), which eventually calls the content_types callback. The issue is that ctools_content_get_subtype() gets called later by panels_renderer_editor->ajax_style_type(), passing the pane id for a non-reusable pane and an undefined index is returned.
Proposed resolution
Decouple ajax_style_type() from calling ctools_content_get_subtype() and load the pane title by calling ctools_content_admin_title().
Remaining tasks
- Reviews
User interface changes
n/a
API changes
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | undefined_index_title-2366389-11.patch | 833 bytes | das-peter |
Comments
Comment #1
heddnFigured out what needed to be called to load a title. Let's see how this fares with testing.
Comment #2
heddnComment #3
mglamanFixes issue for me with Fieldable Panel Panes and styling (no more Pane style for ""). I wanted to RTBC, but I noticed the call for ctools_content_get_subtype() was no longer needed. Including patch to remove this line.
Comment #5
heddnI'm OK with marking RTBC on #3 if you are @mglaman; the change to remove a non-used variable is a good one.
Comment #6
mglamanYep!
Comment #7
heddnComment #8
mrjmd CreditAttribution: mrjmd commentedComment #9
japerryLooks good. Committed.
Comment #11
das-peter CreditAttribution: das-peter commentedSorry to re-open this but it seems like this change triggers a bug in ctools
ctools_content_admin_title()/ctools_context_required::filter().ctools_content_admin_title()says context is optional but doesn't handle it properly.So
NULLis passed on as context which will finally fail inctools_context_required::filter()where theNULLis handled as object. This leads to an error like:Fatal error: Call to a member function is_type() on a non-object in /Users/matthias-diez/dev/projects/postauto/sites/all/modules/contrib/ctools/includes/context.inc on line 147I suggest we circumvent that now by just passing the display context like in other places. But we should fix the empty property handling in
ctools_content_admin_title()eventually and ensure only a proper context / context array is passed on.Comment #13
japerryHrmm yah I don't want to fix the admin title function quite yet, that'll take a bit more time to debug. It looks like there are a few functions there that haven't been really looked at since 2010, so I worry that moving even simple things like NULLs and FALSE (since some are strict comparisons) could cause problems.
In the meantime, this is committed.