Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Oct 2014 at 08:45 UTC
Updated:
2 Dec 2014 at 20:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerAdding a related issue
Comment #2
dawehnerSymfony 2.6 is not yet out.
Comment #3
wim leersHeh :) Who says Drupal moves slowly? :)
Comment #4
rcross commentedshould we be planning on upgrading to symfony 2.7 considering that is the next expected LTS release? http://symfony.com/roadmap (May 2015)
Comment #5
dawehner@rcross
Yeah we have to go to 2.7 anyway, but yeah 2.6 for now is enough.
I'll post a patch to see whether we break anything here.
Comment #7
dawehnerHa, we need to adapt our compiled routes.
Comment #8
rcross commentedNot sure why we need to explicitly add the symfony/debug dependency.
Also, this seems to remove quite a few things which I'm unsure if they are used - symfony/process and looks like some of the validation
Comment #9
hussainwebIt seems 2.6 will be released in November. I think we should be good to go with this. I just wonder if it will get in considering the new commit policy.
Comment #10
mile23Composer updates and unit tests pass with
"2.6.*@beta", which is a little more semantically correct.But yah, how soon will Symfony flip the switch on 2.6 or 2.7?
Also: #2375997: Avoid tying Drupal 8's composer.json to specific package commits.
Comment #11
dawehnerWell, Using any kind of beta for now is fine for me. I just decided to come up with the most simplest solution.
http://symfony.com/doc/current/contributing/community/releases.html describes exactly when symfony 2.7 will be released.
Comment #12
mile23#2375997: Avoid tying Drupal 8's composer.json to specific package commits. makes it so we can do
composer updatenow, for current needs, without having to decide which version of Symfony to use.Comment #13
tstoecklerYeah, #10 is a nice trick, I hadn't thought of that. I don't think it really matters. What does matter is that we start using this and perhaps find the one or the other bug that we can fix before they go stable.
Let's do this.
Comment #14
catch@dawehner is https://www.drupal.org/files/issues/interdiff_8011.txt the only change outside of composer.json?
@hussainweb library updates are encouraged right up until 8.0.0, see:
#2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?
Agreed with getting on the beta now especially since there's a green patch.
Comment #15
dawehnerYes, it is the only thing.
Note: This does not only solve #2345725: Query parameters are not decoded the same as the path portion of a URL but also #1964922: When building a route, store the regexp at the same time.
Comment #16
wim leersIf it fixes #1964922: When building a route, store the regexp, it'd be interesting to see profiling numbers, I think? :)
Comment #17
dawehnerFeel free to do it :)
Comment #18
dawehnerComment #19
catchOK I opened #2377281: Upgrade to Symfony 2.6 stable and left a note in there to check out the symfony/debug dependency. This is important to flush out any issues early so committed/pushed to 8.0.x, thanks!
Committed/pushed to 8.0.x, thanks!
Comment #20
amateescu commentedI think the title should reflect the actual version we're upgrading to.
Comment #22
cilefen commentedThe commit message is not accurate as per #20.