Update CMF routing to 1.3 and remove old code

I guess you wanted to set this to needs review?

5 files changed, 39 insertions, 263 deletions.

Yummy. :-)

+++ b/core/lib/Drupal/Core/Routing/RouteProvider.php
@@ -324,4 +326,28 @@ static function getSubscribedEvents() {
+  public function getRoutesPaged($offset, $length = NULL) {
+    $routes = $this->connection->select($this->tableName, 'router')
+      ->fields('router', ['name', 'route'])
+      ->range($offset, $length)
+      ->fetchAllKeyed();

According to PagedRouteProviderInterface, if $length is null then all routes should be returned. That means the range() method should only be called if($length).

(Thanks to znerol for catching this.)

Other than that, I think this looks fine.

Library update -> critical.

+++ b/core/vendor/composer/installed.json
@@ -2589,6 +2529,7 @@
+<<<<<<< ours

@@ -2611,16 +2552,57 @@
+>>>>>>> theirs
...
+<<<<<<< ours
...
+>>>>>>> theirs
...
+<<<<<<< ours

@@ -2645,6 +2627,21 @@
+>>>>>>> theirs

Oops.

Please ignore this if I am being silly, and also if this is not the right time for nitpicks.

1. +++ b/composer.lock
   @@ -1586,17 +1586,16 @@
   -            "target-dir": "Symfony/Cmf/Component/Routing",
   

   Not sure about this, but did you mean to remove "target-dir"?

2. +++ b/core/vendor/symfony-cmf/routing/.travis.yml
   @@ -0,0 +1,31 @@
   +env: ¶
   

   Nitpick: Trailing whitespace.

mbrett: composer.lock is a generated file, and any code in /core/vendor is 3rd party code, not ours. Both should be largely ignored.

Changes to installed.json accounted for an extra 130 KB of patch? Apparently so. All the more reason that we need to stop checking vendor into Git. :-(

+++ b/core/lib/Drupal/Core/Routing/RouteProvider.php
@@ -324,4 +326,32 @@ static function getSubscribedEvents() {
+    if ($length) {

This still does not look 100% correct to me. If something passes 0 or "" (for whatever silly reason), then all routes will be loaded. Why not use isset($length) which conforms exactly to the interface.

in IRC

09:07 alexpott
dawehner: do you have any thoughts on Znerol's comment?
09:08 dawehner
alexpott: he is right

Either way.

Deleting all of that now-unnecessary code is lovely. I was concerned that doing so might break a crap ton of modules during beta, but the hunks in this patch seem to be limited to Composer, Symfony CMF, deleting said unnecessary code, and some additional test coverage. The one exception is core/lib/Drupal/Core/Routing/RouteProvider.php but this seems to be far enough under the covers that the disruption is minimal. Updating this library is also in service of resolving another core issue at #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0, so I think we are good to go from the standpoint of https://www.drupal.org/contribute/core/beta-changes.

Committed and pushed to 8.0.x. Thanks!