Problem/Motivation

There are about 10 of these messages every hour in my logs.

"MailChimp API call to lists/subscribe failed:
Internal Server Error"

It's happening on cron, and I suspect that the emails are blocked from being subcribed as many of them look a bit spammy looking.

Proposed resolution

Capture the output from the MailChimp API with more details and prevent the error throw. Maybe watchdog info depending on the error message.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#7 mailchimp_api_call_to-2362345-7.patch977 bytesjoelpittet
#4 mailchimp_api_call_to-2362345-4.patch562 bytesjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: "MailChimp API call to <em class="placeholder">lists/subscribe</em> failed: Internal Server Error" » "MailChimp API call to "lists/subscribe" failed: Internal Server Error"
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: "MailChimp API call to "lists/subscribe" failed: Internal Server Error" » MailChimp API call to "lists/subscribe" failed: Internal Server Error
Related issues: +#2327343: Possible Mollom integration to curb SPAM subscriptions

Possibly tangentially related #2327343: Possible Mollom integration to curb SPAM subscriptions

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Related issues: +#2290105: Surface Mailchimp API errors to watchdog

This helped out a bunch #2290105: Surface Mailchimp API errors to watchdog and it turns out that it's failing on
Internal Server Error: The email type must be one of: "html" or "text"

And it's inside the cron job. Will dig deeper to resolve this and where to put that email type.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new mailchimp_api_call_to-2362345-4.patch562 bytes

I think this is the only place where $format may be something that is not 'html'.

Will confirm if this fixes the errors on my server.

Status: Needs review » Needs work

The last submitted patch, 4: mailchimp_api_call_to-2362345-4.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Those test fails have nothing to do with my path, btw

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Priority: Normal » Major
StatusFileSize
new mailchimp_api_call_to-2362345-7.patch977 bytes

Please release the 3.x branch. Here is the actual problem, the arguments are out of order for the cron job.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: mailchimp_api_call_to-2362345-7.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Reviewed & tested by the community
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Needs review

Whoops...

darkodev’s picture

darkodev commented

RTBC

Reviewed and looks good. Change in order of arguments and default for format argument seems appropriate.

darkodev’s picture

darkodev commented
Status: Needs review » Reviewed & tested by the community
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-3.1 » 7.x-3.11

Could you make a 7.x-3.x branch? Bumping this to the latest 3.x.

ruscoe’s picture

ruscoe commented
Version: 7.x-3.11 » 7.x-3.2

7.x-3.11 no longer exists. Switching to 7.x-3.2.

ruscoe queued 7: mailchimp_api_call_to-2362345-7.patch for re-testing.

  • ruscoe committed 0637032 on 7.x-3.x authored by joelpittet 
    Issue #2362345 by joelpittet: Fixed order of arguments for subscribe...
ruscoe’s picture

ruscoe commented

Thanks for the fix, @joelpittet! Patch committed to the dev branch.

There's also now a 7.x-3.x-dev branch, in case you want to patch against it for future issues.

ruscoe’s picture

ruscoe commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs review

abhishek_pareek queued 7: mailchimp_api_call_to-2362345-7.patch for re-testing.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs review » Fixed

This work was committed 8 months ago and is included in the 3x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.