Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Context integration
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Oct 2014 at 09:01 UTC
Updated:
27 Jan 2016 at 19:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
normunds lauva commentedI managed to solve this using setting "META TAGS" in view edit page and changing meta fields there.
Comment #2
damienmckennaComment #3
marcelovaniAre we suggesting that the Metatag Context (By path) should have higher priority? In other words, if we create a context by path to set metatags, that should override Metatag views?
Comment #4
marcelovaniI have changed the hook from page_build() to page_alter() which is the same hook used by Metatag Views
Then I make sure that Metatag Context always runs last
Also, I am not sure why we were using 'global' as instance. I think it makes sense changing it to 'by_path'.
Here is how I tested this:
Comment #5
marcelovaniPatch here to be reviewed
Comment #6
marcelovaniFew more fixes and tests updated
Comment #7
damienmckennaThis needs to be rerolled.
Comment #8
marcelovaniRe-rolled the patch #6.
I didn't have time to do the tests, please review the patch and if everyone is happy we can port the tests from #6
Comment #9
marcelovaniIf you are wondering why I removed hook_preprocess_html(), it's because I don't see any reason for it to be there.
I assume it was an attempt to override the page title, please correct me if I am wrong.
I tested the code without this hook and I was able to override page title with no problems.
Comment #10
damienmckennaCommitted. Thanks!