Problem/Motivation

#2246647: Rename PluginBag to LazyPluginCollection has been commited on 17.10.2014 and renames plugin "bags" to "collections". This patch applies this change/refactoring to page_manager.

Proposed resolution

Rename all the bags.

CommentFileSizeAuthor
#6 interdiff-1-6.txt1.34 KBfrega
#6 page_manager-bag-to-collection-renaming-2360845-6.patch30.13 KBfrega
#1 page_manager-bag-to-collection-renaming-2360845-1.patch29.28 KBfrega

Comments

frega’s picture

frega commented
Issue summary: View changes
StatusFileSize
new page_manager-bag-to-collection-renaming-2360845-1.patch29.28 KB
frega’s picture

frega commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: page_manager-bag-to-collection-renaming-2360845-1.patch, failed testing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Can we wait on merging this until after there is a page_manager 1.0-alpha2 release that is compatible with Drupal 8.0.0-beta2? This rename is in HEAD after Drupal 8.0.0-beta2.

frega’s picture

frega commented

Sorry, dsnopek i forgot to add that important note/suggestion of yours. Will fix test failures later tonight.

frega’s picture

frega commented
StatusFileSize
new page_manager-bag-to-collection-renaming-2360845-6.patch30.13 KB
new interdiff-1-6.txt1.34 KB

Rerolled patch, to reflect renaming of getCacheTag to getCacheTages (#2351847) and replaced a vestigial "bag"-reference in a comment.

As stated in #4 - not intended or commit before 8.0.0-beta2.

frega’s picture

frega commented
Status: Needs work » Needs review
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

Thanks, committed after tagging.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.