Active
Project:
Drupal Security Team
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Oct 2014 at 19:19 UTC
Updated:
22 Nov 2014 at 10:08 UTC
Jump to comment: Most recent
Comments
Comment #1
cjoy commentedwould this also cover updates to *old* issues?
It appears to me that one of the factors that allowed #2146839: Database ExpandArguments placeholder naming issues when using array to remain unnoticed, was the delayed (and somewhat silent) escalation.
Comment #2
gregglesThat makes sense to me. I don't think anyone particularly watches the 7.x-major queue any closer than they do 7.x-normals.
And to be useful, this tool would have to look at all issues including those filed as minor.
Comment #3
kattekrab commentedGreat suggestion Greg. Something similar crossed my mind when I saw that issue. Some kind of keyword alert would be useful at our scale.
Comment #4
Bojhan commentedActually, can we not monitor on this - as people are writing it and serve them a message? I would like to aim for prevention first. We've added too many messages for them to be of use for signalling, we need a more active way.
Comment #5
marcvangendBojhan, I think that is a great approach. We could use javascript, or check for those keywords during the form validation, and add a confirmation step if one or more keywords are present.
Comment #6
david straussOn some systems like Launchpad, the issue tracker specifically asks if something is a security issue as part of the filing process. Now, I know our normal tracker can't handle them directly, but we could disable submission to the normal queues and provide instructions for the right place to send it.
Comment #7
David_Rothstein commentedA problem with this might be that there will be many false positives. If a warning popped up at me every time I typed the word "security" in a comment I would probably get annoyed pretty quickly.
For this reason I think it would be better to start with the initial proposal and see how it goes. Easier to get done, and no end-user UX issues to worry about :)
Drupal.org sort of does that too, although it's probably not noticeable enough: #2358373: Improve clarity of the reporting security issues warning
Comment #8
plach@David_Rothstein:
I think I could live with an extra-confirmation step (form rebuild) if my node/comment content included a problematic keyword. Not sure how you would like to notify the security team, e.g. by mail or by flagging the issue so there's a specific queue to check, but I think this confirmation step would have the potential to highly reduce the number of items that require immediate attention from a security team member. And thus reducing also the risk to devaluate the importance of these notifications.
Comment #9
Bojhan commented@David but this is only about new issues, and then only core?
Comment #10
mlhess commentedAn easy way to do this it to build a solr query and email it out to the team daily.
As far as old issues, we could run this on project issues only for the X years.
Next step format the results for email. I would guess the title, a link, and the content field as returned by solr will be enough. Looking the results would become part of triage duty.
Comment #11
dokumori commented