Remove usage of form_get_cache() and form_set_cache()

Greping I found also these:

$ grep -nr form_get_cache core
...
core/lib/Drupal/Core/Form/FormCache.php:186:    // to prevent legacy code operating directly with form_get_cache and
core/modules/system/src/Controller/FormAjaxController.php:131:    // replaced from within form_get_cache. If this is the case, it is also
core/modules/system/tests/modules/form_test/src/Controller/FormTestController.php:44:   * form_get_cache and stored using form_set_cache after manipulation. This

But it seems that in core/modules/system/tests/modules/form_test/src/Controller/FormTestController.php we should keep the references because it tells about Drupal 6.

Thank you. Looks good.

Can we combine #2355185: Remove usage of form_set_cache(). form_get_cache and form_set_cache should be removed together. Having one without the other - both patches are rtbc but they of course conflict. Let's add the form_set_cache() to this patch since this patch has the smaller nid.

+++ b/core/lib/Drupal/Core/Form/FormCache.php
@@ -183,8 +183,9 @@ public function setCache($form_build_id, $form, FormStateInterface $form_state)
+    // to prevent legacy code operating directly with \Drupal::formBuilder()->getCache()

Need to re-flow this comment to be less than 80 characters

Need to re-flow this comment to be less than 80 characters

Done in this patch.

This seems to be ready. Only the following instances remains which @claudiu.cristea suggests to keep in #4

For form_get_cache():

core/modules/system/src/Tests/Form/FormCacheTest.php:64:    $cached_form = form_get_cache($this->form_build_id, $cached_form_state);
core/modules/system/tests/modules/form_test/src/Controller/FormTestController.php:44:   * form_get_cache and stored using form_set_cache after manipulation. This
core/includes/form.inc:28:function form_get_cache($form_build_id, FormStateInterface $form_state) {

For form_set_cache():

core/modules/system/tests/modules/form_test/src/Controller/FormTestController.php:44:   * form_get_cache and stored using form_set_cache after manipulation. This
core/includes/form.inc:40:function form_set_cache($form_build_id, $form, FormStateInterface $form_state) {

Committed and pushed to 8.0.x. Thanks!

Needs follow-up

+++ b/core/modules/system/src/Controller/FormAjaxController.php
@@ -116,7 +116,7 @@ protected function getForm(Request $request) {
+    $form = \Drupal::formBuilder()->getCache($form_build_id, $form_state);

suppose service should be properly injected to controller

d.o lags

-

Agreed. Let's do one thing at a time. :)

we still have one more form_get_cache in FormCachetest::testCacheToken.

I updated the patch in #2355187 to take out that one also.

@skipyT, see #4

@claudiu.cristea: see https://www.drupal.org/node/2355187#comment-9249859 One test was failing because of that occurrence. And it is not the FormTestController, it is the FormCacheTest. Did I misunderstood something?