Remove form_get_cache()

we still have one form_get_cache in FormCachetest::testCacheToken, thats why the tests are failing. I updated the patch.

Can we also remove form_set_cache() too - and also add this issue to the relevant CR.

Also we should be giving a_thakur commit credit too since they worked on #2359441: Remove form_set_cache() from form.inc

Done changes according to #7.

In core/modules/system/tests/modules/form_test/src/Controller/FormTestController.php
The docblock of storageLegacyHandler function refers to form_get_cache and form_set_cache, my question is: should modify the dockblock?

  /**
   * Emulate legacy AHAH-style ajax callback.
   *
   * Drupal 6 AHAH callbacks used to operate directly on forms retrieved using
   * form_get_cache and stored using form_set_cache after manipulation. This
   * callback helps testing whether \Drupal::formBuilder()->setCache() prevents
   * resaving of immutable forms.
   */

@rpayanm - nice find - yep it needs updating.

fixed :)

Applied the patch. It applies cleanly. Manually reviewed the code as well. Changing to RTBC.

+++ b/core/includes/form.inc
@@ -18,30 +18,6 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;

+++ b/core/modules/system/tests/modules/form_test/src/Controller/FormTestController.php
@@ -41,9 +41,9 @@ public function twoFormInstances() {
+   * \Drupal::formBuilder()->getCache() and stored using \Drupal::formBuilder()->setCache()
+   * after manipulation. This callback helps testing whether \Drupal::formBuilder()->setCache()
+   * prevents resaving of immutable forms.

The comments need to break at 80 characters.

Fixed

@ashutoshsngh Thank you. It's better to review create a interdiff ;)

Greetings.

This is covered by the existing change notice at https://www.drupal.org/node/2121003 and is just removing (nearly) dead code at this point, so fine from the standpoint of #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?.

Committed/pushed to 8.0.x, thanks!

I make git pull and not saw the commit, I'll have to do something else?