Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Once #2355179: Remove usage of form_get_cache() and form_set_cache() is in, we can remove form_get_cache() and form_set_cache() completely as part of #2205673: [META] Remove all @deprecated functions marked "remove before 8.0".
Comment | File | Size | Author |
---|---|---|---|
#14 | 2355187-14.patch | 3.04 KB | ashutoshsngh |
#11 | 2355187-11.patch | 3.04 KB | rpayanm |
#11 | 2355187-interdiff.txt | 1.08 KB | rpayanm |
#8 | remove-form_get_n_set_cache-2355187-8.patch | 1.96 KB | ashutoshsngh |
#6 | remove_form_get_cache-2355187-6.patch | 1.57 KB | skipyT |
Comments
Comment #1
legolasboAttached patch removes form_get_cache completely. Leaving this issue in the Active state untill #2355179: Remove usage of form_get_cache() and form_set_cache() gets committed to prevent a test fail.
Comment #2
er.pushpinderrana CreditAttribution: er.pushpinderrana commentedComment #6
skipyT CreditAttribution: skipyT commentedwe still have one form_get_cache in FormCachetest::testCacheToken, thats why the tests are failing. I updated the patch.
Comment #7
alexpottCan we also remove form_set_cache() too - and also add this issue to the relevant CR.
Also we should be giving a_thakur commit credit too since they worked on #2359441: Remove form_set_cache() from form.inc
Comment #8
ashutoshsngh CreditAttribution: ashutoshsngh commentedDone changes according to #7.
Comment #9
rpayanmIn core/modules/system/tests/modules/form_test/src/Controller/FormTestController.php
The docblock of storageLegacyHandler function refers to form_get_cache and form_set_cache, my question is: should modify the dockblock?
Comment #10
alexpott@rpayanm - nice find - yep it needs updating.
Comment #11
rpayanmfixed :)
Comment #12
a_thakur CreditAttribution: a_thakur commentedApplied the patch. It applies cleanly. Manually reviewed the code as well. Changing to RTBC.
Comment #13
alexpottThe comments need to break at 80 characters.
Comment #14
ashutoshsngh CreditAttribution: ashutoshsngh commentedFixed
Comment #15
rpayanm@ashutoshsngh Thank you. It's better to review create a interdiff ;)
Greetings.
Comment #16
catchThis is covered by the existing change notice at https://www.drupal.org/node/2121003 and is just removing (nearly) dead code at this point, so fine from the standpoint of #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?.
Committed/pushed to 8.0.x, thanks!
Comment #17
rpayanmI make
git pull
and not saw the commit, I'll have to do something else?