This is my patch for added roles to name (title's attribute).

CommentFileSizeAuthor
#2 title_added-2355069-1.patch1.24 KBNerOcrO
title_added.patch1021 bytesNerOcrO

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work 
+++ b/masquerade.module
@@ -606,13 +606,10 @@ function masquerade_block_1() {
+          $quick_switch_links[] = l($account->name, $switch_link, array('query' => array('token' => drupal_get_token($switch_link)), 'attributes' => array('title' => t('roles:') . ' ' . implode(', ', $account->roles))));

this is not a right way to display role names.

use a kind of $role_options = array_map('check_plain', user_roles());

NerOcrO’s picture

NerOcrO commented
StatusFileSize
new title_added-2355069-1.patch1.24 KB

And now?

NerOcrO’s picture

NerOcrO commented
Status: Needs work » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work 
+++ b/masquerade.module
@@ -606,13 +606,21 @@ function masquerade_block_1() {
+          foreach ($account->roles as $key => $role) {
+            $roles[] = $role . ' (' . $key . ')';

roles could be added via UI so needs sanitization, check core for usage of the role names

NerOcrO’s picture

NerOcrO commented

Yes, the t() function sanitize this variable : http://cgit.drupalcode.org/drupal/tree/includes/bootstrap.inc?h=7.x#n1466.
More specifically, format_string().

NerOcrO’s picture

NerOcrO commented
Status: Needs work » Needs review
ressa’s picture

ressa
he/him
commented
Status: Needs review » Closed (outdated)

Thanks for working on this. In an attempt to help the maintainers, I am going through some of the Drupal 7 issues, and closing them, since Drupal 7 is EOL.

Maintainers should grant credit for the great work to the relevant users, even if the patch did not get committed: https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett....

Since Drupal 7 is EOL, we can probably close this issue, but feel free to re-open if this is still relevant, and we should consider adding this to the Drupal 11 version?

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.