Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Type in filename causes WSOD when generating a new theme
Comment | File | Size | Author |
---|---|---|---|
#6 | scrThemesInstalled.png | 25.05 KB | greta_drupal |
#2 | at_typo-in-filename-2354761.patch | 3.93 KB | clivesj |
Comments
Comment #1
clivesj CreditAttribution: clivesj commentedPatch renames fileSavePrepare.php to FileSavePrepare.php
Comment #2
clivesj CreditAttribution: clivesj commentedSorry, this is a better patch
Comment #3
clivesj CreditAttribution: clivesj commentedComment #4
clivesj CreditAttribution: clivesj commentedComment #5
greta_drupal CreditAttribution: greta_drupal commentedConfirming this patch (filename change only) resolves the Theme UI "AT Generator" process.
Comment #6
greta_drupal CreditAttribution: greta_drupal commentedSince my original post herein is no longer applicable (resolved it), and I can't delete this post, I'll use it to say:
WOW!! This UI/UX is so nice and chocked full of features. A theme like this makes Drupal a viable CMS to rival WordPress in ease of non-tech staff use. Think that I'll need to retire now. My theming skills won't be needed. But, I will continue to report any bugs or suggestions to the Issue queue (e.g., not seeing options implemented or even my custom blocks showing).
Comment #7
Jeff Burnz CreditAttribution: Jeff Burnz commentedGood catch with the file naming mistake, I'll apply and commit this patch shortly, thanks clivesjs, and greta_drupal for your review also.
Just as a side node the theme is moving pretty fast in DEV right now (mainly behind the scenes code changes), since this was, up until now, a lot of prototype code and now is being refined into production ready code.
Working my ass off here, so thanks a lot for the feedback greta_drupal, I work in the UI a LOT :)
One thing you should know, when the theme finally ships there will be heaps of layouts you can just drop into your sub-theme, these will probably be stored on github or on my site, I haven't decided as yet, but I have about 40 different layouts drawn up and loads of video tutorials being made etc etc.
Comment #8
greta_drupal CreditAttribution: greta_drupal commentedPlease let me know how I can help. Not a module developer, but if you'd like something specific tested right away, please let me know.
Comment #9
Jeff Burnz CreditAttribution: Jeff Burnz commentedI want to know if you think the layout system in the theme sucks or not, I know its a little buggy but I have a complete different idea that I am thinking about implementing, basically to change it from selecting a "page layout" to a system where you select a layout per breakpoint, per row.
Say for example you have a row with 3 regions - lets say 2 sidebars and and a main content region, the idea is that you an select a layout just for these three regions. You do that for each row the theme supports. The site builder plugin supports 8 rows, so for each row you would select a layout.
You would do this for each breakpoint supported by the theme, so if the theme has three breakpoints, lets say mobile, tablet and widescreen, you setup the row layouts for each breakpoint.
Think of a row as things like : Header, Features, Main, Sub-features, Footer etc, within each of these rows are regions. If you are familiar with Omega zones and regions then you are probable familiar with the idea.
This is actually the original idea for the theme, but only at this stage does it have all the moving parts to make something like this really work.
Comment #10
greta_drupal CreditAttribution: greta_drupal commentedBasically building in Panels to AT. Honestly, I hadn't yet got the theme (my subtheme) to even 'work' -- e.g., my assigned blocks did not show for the AT subtheme, nor did any of my AT configurations such as font specs or custom CSS added within the UI. Because of the recent SA, I deleted my whole D8 install before I troubleshot any further.
But, I will say this. The AT thing offers a TON of configuration options, which is good and bad. It is pretty overwhelming in its scope. I think that it would be nice for you to have something like a "get started quick" option that just enabled a basic theme straight away. So, meaning the UI also was very simplistic. Perhaps that is there in the parent theme. I apologize, by habit, I just jumped right into creating a subtheme.
Be sure that there is a layout for no sidebars, no footer, no header. You'd be surprised how often I have wanted this -- TOS, Privacy Policy, or such. In fact, for my homepage, I wanted that initially.
Will report back once I have reinstalled D8 and given it another go. I'll pick a different kind of site to use where I can better test out the awesomeness of AT.
Comment #11
Jeff Burnz CreditAttribution: Jeff Burnz commentedJust wait a few days, I have totally rewritten the layout system and it's and entirely different approach.
Your idea of a basic theme out of the box is exactly how it works, when you create a new sub-theme using the generator you will get a pretty advanced theme strait away.
I'm going to make some videos quite soon on how to use the layout system and other theme settings, and how they can be used in the real world.
Comment #12
greta_drupal CreditAttribution: greta_drupal commentedIf you'd like help with written documentation, just let me know, Jeff! (I can even write those based on your videos.) I have really wanted to build a nice theme or 2 for Drupal, for public download. If I recall, you have a skin option in AT. Been nice to have a few skins, then also subthemes. I think that I'll add that to my TO DO list as a community project, and a way to help test out AT for Drupal 8.
Comment #13
Jeff Burnz CreditAttribution: Jeff Burnz commentedThis is fixed, however I did not commit the patch. When I reviewed this code I bit the bullet and rewrote most of it and refactored these classes into methods in two larger classes and added proper interfaces etc, how it should have been right from the start.
It should all be working now, I've been running the Theme Generator all day slamming the bugs out of it (still more to go with color module stuff having changed recently), but otherwise you can generate a Standard theme no problem and a Skin, not sure about clones at this stage and Minimal is just broken until I get that sorted out: #2375033: Minimal kit doesn't work