Looks like the tpl.php got mangled somehow, and the alt tag ended up on the wrong element (alt tag on an "a" is not valid - see http://www.w3.org/TR/html5/text-level-semantics.html#the-a-element and http://www.w3.org/TR/html5/dom.html#global-attributes). This is also an accessibility issue.

Attached patch moves it to the "img" tag, and also line-breaks the tags/attributes a bit more simply.

CommentFileSizeAuthor
#3 formatted_tweets_img_alt-2354555-3.patch673 bytesowen barton
#1 formatted_tweets_img_alt-2354555-1.patch671 bytesowen barton

Comments

owen barton’s picture

owen barton commented
StatusFileSize
new formatted_tweets_img_alt-2354555-1.patch671 bytes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

The img tag needs to be self-closing..

owen barton’s picture

owen barton commented
Status: Needs work » Needs review
StatusFileSize
new formatted_tweets_img_alt-2354555-3.patch673 bytes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Hit save before writing the message, sorry.

This patch resolves the issue it said it would. It does ever-so-slightly changes the HTML so that there's whitespace around the image tag, some may wish to change that, but I don't think it's a major issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2402307: Plan for Twitter v7.x-5.9 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs review

Triggering the testbot.

DamienMcKenna queued 3: formatted_tweets_img_alt-2354555-3.patch for re-testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Related issues: +#2402309: Plan for Twitter v7.x-6.0 release

Committed to both the 7.x-5.x and 7.x-6.x branches. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.