update_variables_to_config('tracker.settings', array(
    'tracker_batch_size' => 'cron_index_limit',
  ));

See parent issue #2181257: [meta] Variables to config migration [d7] for instructions.

Contributors

@joshtaylor wrote the original migration; @phenaproxima updated it for HEAD and added a test.

git commit -m 'Issue #2353777 by phenaproxima, joshtaylor: Variable to config: tracker.settings [d7]'

CommentFileSizeAuthor
#20 2353777-20.patch2.42 KBphenaproxima
#16 2353777-16.patch2.42 KBphenaproxima
#13 2353777-13.patch2.42 KBphenaproxima
#12 2353777-12.patch2.42 KBphenaproxima
#9 2353777-9.patch2.41 KBphenaproxima
#8 2353777-8.patch1.86 KBphenaproxima
#7 2353777-7.patch2.39 KBphenaproxima
#6 2353777-6.patch3.01 KBphenaproxima
#3 2353777-3.patch2.91 KBphenaproxima

Comments

jcost’s picture

jcost commented
Project: IMP » Drupal core
Version: » 8.0.x-dev
Component: Code » migration system
Status: Active » Needs work

Will need to be submitted again to Core since moving from sandbox.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Parent issue: #2181257: [meta] Variables to config migration [d7] » #2500535: Upgrade path for Tracker 7.x
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2353777-3.patch2.91 KB

Gentlemen (and women)...BEHOLD!

Status: Needs review » Needs work

The last submitted patch, 3: 2353777-3.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue summary: View changes

@joshtaylor wrote the original migration in #2132207: Variable to config: tracker.settings [d7], so I'm giving him credit.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2353777-6.patch3.01 KB

Forgot annotation on the test class.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2353777-7.patch2.39 KB

Re-rolled. No interdiff due to conflicts in the {variable} table dump.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2353777-8.patch1.86 KB

Re-rolled in accordance with #2533886: [meta] Move module-specific migration support into the particular modules supported.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2353777-9.patch2.41 KB

Whoops, forgot to include the migration template!

The last submitted patch, 8: 2353777-8.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 9: 2353777-9.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2353777-12.patch2.42 KB

Man, screw up one namespace and they hound you forever...

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2353777-13.patch2.42 KB

Ugh, missed a spot (file doc comment).

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

git archeology finds 

+  update_variables_to_config('tracker.settings', array(
+    'tracker_batch_size' => 'cron_index_limit',
+  ));

from #1591412: Convert tracker settings to configuration system and I checked the change in tracker_cron and it's the variable name change so apparently that is the variable name, no matter how odd.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 13: 2353777-13.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2353777-16.patch2.42 KB

Re-rolled due to conflicts in the {variable} table dump (which is why there's no interdiff).

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community

mikeryan queued 16: 2353777-16.patch for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 16: 2353777-16.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2353777-20.patch2.42 KB

Re-rolled.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Variable to config: tracker.settings [d7] » Migrate Tracker module variables in D7
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 2fbb1a0 on 8.0.x 
    Issue #2353777 by phenaproxima, joshtaylor, chx: Variable to config:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.