It's a common practice by Twitter users, when a reference to an account has to be put in first position without being a direct message, to precede it with a point (.@account).

This causes an undesired formatting in the link, which is formatted as a mailto link by core's filter.

CommentFileSizeAuthor
#16 twitter-n2353371-16-6.x-5.x.patch6.37 KBdamienmckenna
#15 twitter-n2353371-15-7.x-5.x.patch7.38 KBdamienmckenna
#14 twitter-n2353371-13-7.x-6.x.patch7.38 KBdamienmckenna
#12 twitter-n2353371-12-7.x-6.x.patch7.34 KBdamienmckenna
#11 twitter-n2353371-11-7.x-5.x.patch7.34 KBdamienmckenna
#10 twitter-n2353371-10-7.x-5.x.patch5.49 KBdamienmckenna
#9 twitter-n2353371-9-6.x-5.x.patch1.22 KBdamienmckenna
#8 twitter-n2353371-8-7.x-6.x.patch1.43 KBdamienmckenna
#7 twitter-n2353371-7-7.x-5.x.patch1.43 KBdamienmckenna
#5 twitter-n2353371-5-7.x-5.x.patch1.41 KBdamienmckenna
#4 twitter-n2353371-4-7.x-5.x.patch1.51 KBdamienmckenna
#1 twitter-undesired-mailto-link-2353371-1-7.x.patch1.42 KBfilippo.ledda

Comments

filippo.ledda’s picture

filippo.ledda commented
StatusFileSize
new twitter-undesired-mailto-link-2353371-1-7.x.patch1.42 KB

Here is a simple patch, adding the particular case and calling filter at the end of the process. Can be surely perfected to be more general.

filippo.ledda’s picture

filippo.ledda commented
Status: Active » Needs review

Setting to needs review, the patch is now some months working and may be easily included in next releases.

Status: Needs review » Needs work

The last submitted patch, 1: twitter-undesired-mailto-link-2353371-1-7.x.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.8 » 7.x-5.x-dev
Status: Needs work » Needs review
StatusFileSize
new twitter-n2353371-4-7.x-5.x.patch1.51 KB

Rerolled, and fixed some minor coding standards mistakes.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new twitter-n2353371-5-7.x-5.x.patch1.41 KB

I wonder if it'd work without the period in front of the @ symbol?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Category: Feature request » Bug report
Priority: Minor » Normal
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new twitter-n2353371-7-7.x-5.x.patch1.43 KB

Added a comment. This is for 7.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 7.x-6.x-dev
StatusFileSize
new twitter-n2353371-8-7.x-6.x.patch1.43 KB

This is for 7.x-6.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 6.x-5.x-dev
StatusFileSize
new twitter-n2353371-9-6.x-5.x.patch1.22 KB

This is for 6.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-5.x-dev » 7.x-5.x-dev
StatusFileSize
new twitter-n2353371-10-7.x-5.x.patch5.49 KB

So I did some more testing and it turns out that the problem was a little more complicated - the patch didn't fix the problem and it also wasn't going to fix the "Formatted tweet" views field. I've moved the text formatting into its own function twitter_filter_message() and reworked the output to use it.

This patch is for 7.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new twitter-n2353371-11-7.x-5.x.patch7.34 KB

This has been refactored to leverage the existing text filter functions. I've also improved those functions slightly by making the $filter argument optional and by giving them some documentation.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 7.x-6.x-dev
StatusFileSize
new twitter-n2353371-12-7.x-6.x.patch7.34 KB

Ported to 7.x-6.x.

Status: Needs review » Needs work

The last submitted patch, 12: twitter-n2353371-12-7.x-6.x.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new twitter-n2353371-13-7.x-6.x.patch7.38 KB

A slightly updated patch for 7.x-6.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 7.x-5.x-dev
StatusFileSize
new twitter-n2353371-15-7.x-5.x.patch7.38 KB

For 7.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 6.x-5.x-dev
StatusFileSize
new twitter-n2353371-16-6.x-5.x.patch6.37 KB

For 6.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2402311: Plan for Twitter v6.x-5.2 release
Related issues: +#2402307: Plan for Twitter v7.x-5.9 release, +#2402309: Plan for Twitter v7.x-6.0 release

The last submitted patch, 14: twitter-n2353371-13-7.x-6.x.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 76943c4 on 6.x-5.x 
    Issue #2353371 by DamienMcKenna, filippo.ledda: Fix tweet formatting so...

  • DamienMcKenna committed e197c11 on 
    Issue #2353371 by DamienMcKenna, filippo.ledda: Fix tweet formatting so...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.