"Set breadcrumb" action needs to be ported to Rules 8.x-3.x version.

Comments

kalman.hosszu’s picture

fago’s picture

Assigned: kalman.hosszu » Unassigned

I guess the assignment is deprecated meanwhile? :-)

a.milkovsky’s picture

Assigned: Unassigned » a.milkovsky

I will work on it

a.milkovsky’s picture

Started working here: https://github.com/milkovsky/rules/tree/set-breadcrumb-2351979
I added repo of hosszukalman to remotes.

Why do we have SendMail.php here https://github.com/hosszukalman/rules/compare/feature/set-breadcrumb-action for this task?

dasjo’s picture

@a.milkovsky the set-breadcrump-action feature branch from hosszukalaman was based accidentally based on another feature branch instead of 8.x-3.x.

fago’s picture

Status: Active » Closed (won't fix)

Discussed this with a.milkovsky and fubhy. There is no drupal_set_breadcrumb() equivalence in d8 core any more - so we cannot easily provide an action for it. It's not the job of Rules to replicate this API - so if another module does so it can expose this action.
As breadcrumbs are really tied to routes in d8 and as they should be generated based upon page context, it seems to make sense to have something like this in page manager.

-> Setting as won't fix.

fago’s picture

Assigned: a.milkovsky » Unassigned
a.milkovsky’s picture

Issue tags: +SprintWeekend2015

I agree the breadcrumb system is different to one in drupal 7.
We can't set breadcrumb on the path that does't exist in routing. The issue can't be fixed without providing a fake route what is not a good way.
Let's leave this task to module that is more connected to routing. Would be good to implement in "Page manager" or port https://www.drupal.org/project/path_breadcrumbs to drupal 8.