How to reproduce

  1. Add a new view.
  2. Add a new filter criterion: Content: Tags (field_tags).
  3. Go to the second step. In the header you'll see that there is the "views-progress-indicator" ovelapping with the close button.

Here is an screenshot:

CommentFileSizeAuthor
#9 interdiff-5-9.txt402 bytestadityar
#9 overlaping_elements_in_the_titlebar-2349863-9.patch539 bytestadityar
#8 Screen Shot 2015-01-17 at 8.42.33 PM.png146.31 KBtadityar
#5 overlaping_elements_in_the_titlebar-2349863-5.patch542 bytesmukeysh
#5 views-header-image-overlap.png95.72 KBmukeysh
#4 testing__المحتوى____localhost.png153.18 KBtadityar
test-view.png226.54 KBckrina

Comments

lewisnyman’s picture

lewisnyman
he/him
commented
Component: CSS » views_ui.module
Issue tags: +frontend, +CSS, +Usability, +VDC
euphoric_mv’s picture

euphoric_mv commented

Does "views-progress-indicator" need to be here, so just to hide it with CSS or needs to be removed from HTML?

dawehner’s picture

dawehner
Primary language German
commented

Well, the progress indicator is not pointless, so removing it, is a bad idea.

I would rather suggest to make it actually visible.

tadityar’s picture

tadityar commented
StatusFileSize
new testing__المحتوى____localhost.png153.18 KB

When I checked for the RTL view the progress indicator was "of 2 2" instead of "2 of 2" is this inside the scope of this issue? Or should I make a new issue about that and tag it with the multilingual initiative tag?

Screenshot:

rtl

mukeysh’s picture

mukeysh commented
StatusFileSize
new views-header-image-overlap.png95.72 KB
new overlaping_elements_in_the_titlebar-2349863-5.patch542 bytes

I have added patch for this.

After applying patch:

tadityar’s picture

tadityar commented
Status: Active » Needs review

Setting to Needs Review for testing.

dawehner’s picture

dawehner
Primary language German
commented

This looks nice IMHO.

Can we also get a RTL review?

tadityar’s picture

tadityar commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2015-01-17 at 8.42.33 PM.png146.31 KB

Screenshot of the RTL-view. Since this looks nice and the text doesn't overlap at any width I'm setting this to RTBC. Maybe the issue on #4 should be in a new issue.

ss

tadityar’s picture

tadityar commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new overlaping_elements_in_the_titlebar-2349863-9.patch539 bytes
new interdiff-5-9.txt402 bytes

oh lol wait sorry I forgot that core uses 3-letter color code when possible so I'm changing the patch to #fff this shouldn't change the interface though.

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Reviewed & tested by the community

This is a quick fix, in the future we can implement a proper design. Thanks for the screenshots and the patches.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: overlaping_elements_in_the_titlebar-2349863-9.patch, failed testing.

tadityar’s picture

tadityar commented

Random test failures, it's being fixed here #2411703: Random fail in Drupal\user\Tests\UserAdminTest so let's wait for that to land.

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs work » Reviewed & tested by the community

idebr queued 9: overlaping_elements_in_the_titlebar-2349863-9.patch for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

CSS changes are not subject to beta evaluation. Committed 3eea697 and pushed to 8.0.x. Thanks!

  • alexpott committed 3eea697 on 8.0.x 
    Issue #2349863 by tadityar, Mukeysh, ckrina: Overlapping elements in the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.