Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
How to reproduce
- Add a new view.
- Add a new filter criterion: Content: Tags (field_tags).
- Go to the second step. In the header you'll see that there is the "views-progress-indicator" ovelapping with the close button.
Here is an screenshot:
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff-5-9.txt | 402 bytes | tadityar |
#9 | overlaping_elements_in_the_titlebar-2349863-9.patch | 539 bytes | tadityar |
#8 | Screen Shot 2015-01-17 at 8.42.33 PM.png | 146.31 KB | tadityar |
#5 | overlaping_elements_in_the_titlebar-2349863-5.patch | 542 bytes | Mukeysh |
#5 | views-header-image-overlap.png | 95.72 KB | Mukeysh |
Comments
Comment #1
LewisNyman CreditAttribution: LewisNyman commentedComment #2
euphoric_mv CreditAttribution: euphoric_mv commentedDoes "views-progress-indicator" need to be here, so just to hide it with CSS or needs to be removed from HTML?
Comment #3
dawehnerWell, the progress indicator is not pointless, so removing it, is a bad idea.
I would rather suggest to make it actually visible.
Comment #4
tadityar CreditAttribution: tadityar commentedWhen I checked for the RTL view the progress indicator was "of 2 2" instead of "2 of 2" is this inside the scope of this issue? Or should I make a new issue about that and tag it with the multilingual initiative tag?
Screenshot:
Comment #5
Mukeysh CreditAttribution: Mukeysh commentedI have added patch for this.
After applying patch:
Comment #6
tadityar CreditAttribution: tadityar commentedSetting to Needs Review for testing.
Comment #7
dawehnerThis looks nice IMHO.
Can we also get a RTL review?
Comment #8
tadityar CreditAttribution: tadityar commentedScreenshot of the RTL-view. Since this looks nice and the text doesn't overlap at any width I'm setting this to RTBC. Maybe the issue on #4 should be in a new issue.
Comment #9
tadityar CreditAttribution: tadityar commentedoh lol wait sorry I forgot that core uses 3-letter color code when possible so I'm changing the patch to #fff this shouldn't change the interface though.
Comment #10
LewisNyman CreditAttribution: LewisNyman commentedThis is a quick fix, in the future we can implement a proper design. Thanks for the screenshots and the patches.
Comment #12
tadityar CreditAttribution: tadityar commentedRandom test failures, it's being fixed here #2411703: Random fail in Drupal\user\Tests\UserAdminTest so let's wait for that to land.
Comment #13
LewisNyman CreditAttribution: LewisNyman commentedComment #15
alexpottCSS changes are not subject to beta evaluation. Committed 3eea697 and pushed to 8.0.x. Thanks!