drupal_set_message inherits previous style if set to 'status'

It appears that this is a twig template issue, as duplicate classes are added (Each message inherits the previous message's classes). So - the first message gets messages messages--error and the next gets messages messages--error messages--status

It seems that this is because the classes are added to a set of classes that is never reset in between messages.

The attached patch resolves this for me, but I'm not a twig expert, so there may be a better way to store/reset the attributes for each iteration through the loop.

I suspect a1a0cc86c086e8242701ef4a43fbf2398a139886

Sorry - that previous patch included a bunch of irrelevant changes. Revised patch attached.

tests coming

should be red/green

meh merge head first lee

Tested by setting six messages of three different types in random order. All the class names are rendered correctly.

This makes sense, maybe a comment in the template to explain though?

1. +++ b/core/modules/system/src/Tests/Theme/MessageTest.php
   @@ -0,0 +1,39 @@
   +/**
   + * @file
   + * Definition of Drupal\system\Tests\Theme\MessageTest.
   + */
   

   Replace this with "Contains Drupal\system\...".

2. +++ b/core/modules/system/src/Tests/Theme/MessageTest.php
   @@ -0,0 +1,39 @@
   +  /**
   +   * Modules to enable.
   +   *
   +   * @var array
   +   */
   +  public static $modules = array('system');
   

   Use "{@inheritdoc}", this is already documented on the parent class.

Comment only changes, back to rtbc

+++ b/core/modules/system/src/Tests/Theme/MessageTest.php
@@ -2,7 +2,7 @@
- * Definition of Drupal\system\Tests\Theme\MessageTest.
+ * Contains Drupal\system\Tests\Theme\MessageTest.

Contains \Drupal

Fixed here and leaving at RTBC because it's so minor.

Thanks, reviewing patches on your phone--

@skein, yep thanks! Testbot is having a rough day :(

Thanks for the fix and the test!

Committed and pushed to 8.0.x. Thanks!