DrupalUnitTestBase is deprecated, replace with KernelTestBase

@cosmicdreams probably wanted to mark it for review so that the testbot could run.

Attached is a patch that replaces all occurrences of DrupalUnitTestBase with KernelTestBase. It should pass the tests and once it does, we can remove the DrupalUnitTestBase class altogether as a follow-up.

Just a reroll.

-use Drupal\simpletest\DrupalUnitTestBase;
+use Drupal\simpletest\KernelTestBase;

and

-class SomeTest extends DrupalUnitTestBase {
+class SomeTest extends KernelTestBase {

I did not add interdiff, because it would not be helpfull.

The class DrupalUnitTestBase is not deleted. Need a followup for that.

I think this issue should also remove DrupalUnitTestBase, otherwise we will get false positives for tests which were misses. Also, the testbot itself might need fixing, though I'm pretty sure that's not the case.

The way to evaluate a given patch here is to send two patches to the testbot: One which only makes a minor irrelevant change (such as a comment), and one with the real patch. Then we compare the number of results.

For instance, here's the result count for #4, visible by clicking [view] next to the patch:

PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,826 pass(es).

If the number of passes match, things are good.

It might be that we could just compare the number of tests against branch, but that would leave us without a record.

Will need a change notice.

Talked with @daffie in IRC and so here's a couple of patches.

One does nothing but add a comment.

The other changes all occurrences of DrupalUnitTestBase to KernelTestBase and also deletes DrupalUnitTestBase.

How to do this in NetBeans (and probably other IDEs):

1. Refactor KernelTestBase to change its name, and all useages. I renamed it to KernelTestBaseReal.
2. Refactor DrupalUnitTestBase to change its name to KernelTestBase.
3. Delete the file KernelTestBase.php (which used to be DrupalUnitTestBase.php).
4. Refactor KernelTestBaseReal to be KernelTestBase.
5. Done.

Using a process like this is probably more productive than trying to do a re-roll.

Hmm. Worked locally.

Maybe the problem is #2318755: Block Module: Fix documentation that refers to enabling/disabling of modules. It just landed.

With my patch files then.

Hmm. Both sets of tests have a discrepancy between the baseline and the changed number. #7 is off by 10, and #16 is off by 4.

I have posted patches for this issue because there were problems with the testbot. To be clear: I am reviewing the patch from comment #7 that was created by Mile23.

The patch replaces all instances of DrupalUnitTestBase with KernelTestBase and deletes the file with the DrupalUnitTestBase class.
The gets the green light from the testbot.
It all looks good to me, So it gets a RTBC from me.

Followup after commit: I think that the testbot needs to remove some code, so that it does looks for test classes of the type DrupalUnitTestBase.

For the commiter: The patch that I reviewed is 2347999_7.patch.

+++ b/core/modules/serialization/src/Tests/SerializationTest.php
@@ -15,7 +15,7 @@
diff --git a/core/modules/simpletest/src/DrupalUnitTestBase.php b/core/modules/simpletest/src/DrupalUnitTestBase.php

diff --git a/core/modules/simpletest/src/DrupalUnitTestBase.php b/core/modules/simpletest/src/DrupalUnitTestBase.php
deleted file mode 100644

deleted file mode 100644
index 21c53d9..0000000

index 21c53d9..0000000
--- a/core/modules/simpletest/src/DrupalUnitTestBase.php

--- a/core/modules/simpletest/src/DrupalUnitTestBase.php
+++ /dev/null

+++ /dev/null
+++ /dev/null
@@ -1,17 +0,0 @@

@@ -1,17 +0,0 @@
-<?php
-
-/**
- * @file
- * Contains \Drupal\simpletest\DrupalUnitTestBase.
- */
-
-namespace Drupal\simpletest;
-
-/**
- * Base class for integration tests.
- *
- * @deprecated in Drupal 8.x-dev, will be removed before Drupal 8.0.
- *   Use \Drupal\simpletest\KernelTestBase.
- */
-abstract class DrupalUnitTestBase extends KernelTestBase {
-}

Can we actually remove this is a separate issue. Just in case a patch gets committed with using DrupalUnitTestBase. If we do it that way we have simpler reverting options.

@Mile23: Can you do a new patch. I shall do the review.

OK.

So here are two patches. One does the refactor only, and the other does the refactor and deletes DrupalUnitTestBase.

I included a patch with the deletion so the testbot can confirm it all worked.

The patch replaces all instances of DrupalUnitTestBase with KernelTestBase.
The DrupalUnitTestBase class does not get deleted.
The gets the green light from the testbot.
It all looks good to me, So it gets a RTBC from me.

For the commiter: The patch that I reviewed is 2347999_26_refactor_only.patch.

Committed 0bb57ed and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

There was a code comment that needed updating.

diff --git a/core/modules/system/src/Tests/DrupalKernel/DrupalKernelSiteTest.php b/core/modules/system/src/Tests/DrupalKernel/DrupalKernelSiteTest.php
index b65fb1b..59ee3f3 100644
--- a/core/modules/system/src/Tests/DrupalKernel/DrupalKernelSiteTest.php
+++ b/core/modules/system/src/Tests/DrupalKernel/DrupalKernelSiteTest.php
@@ -22,8 +22,8 @@ class DrupalKernelSiteTest extends KernelTestBase {
   public function testServicesYml() {
     $this->assertFalse($this->container->has('site.service.yml'));
     // A service provider class always has precedence over services.yml files.
-    // DrupalUnitTestBase::buildContainer() swaps out many services with
-    // in-memory implementations already, so those cannot be tested.
+    // KernelTestBase::buildContainer() swaps out many services with in-memory
+    // implementations already, so those cannot be tested.
     $this->assertIdentical(get_class($this->container->get('cache.backend.database')), 'Drupal\Core\Cache\DatabaseBackendFactory');
 
     $class = __CLASS__;

Fixed on commit.

Updated change notice here: https://www.drupal.org/node/2271271

Ugh. Jumped the gun.

Follow-up here: #2388043: Remove DrupalUnitTestBase