Coming from #2303765: Make the default 'alt' attribute for Image fields required

But perhaps also related to #2297681: Make the "alt" attribute required in EditorImageDialog

Reproduce:

  1. Create a basic page
  2. Upload an image in ckeditor into the body field
  3. Don't set any alt text. You get a warning that it is a required field
  4. Now fill in some alt text and save
  5. you will be navigated to /editor/dialog/image/basic_htmleditor/dialog/image/basic_html instead of the edit view of the node

There is a test environment setup http://s793132f30f76007.s3.simplytest.me/.

CommentFileSizeAuthor
#2 Upload image drupal.dev_.png64.79 KBundersound3
#2 Create Basic page drupal.dev_.png39.83 KBundersound3
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

I confirmed this error after it was reported. You see the image on /editor/dialog/image/basic_htmleditor/dialog/image/basic_html so it looks like it was successful.. Sadly, you can't do much else.

undersound3’s picture

undersound3 CreditAttribution: undersound3 commented
Issue summary: View changes
FileSize
Create Basic page drupal.dev_.png39.83 KB
Upload image drupal.dev_.png64.79 KB
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Assigned: Unassigned » Wim Leers
Priority: Normal » Major

Confirmed. Recently introduced. I have a strong suspicion I know the root cause. Will fix this next week hopefully.

Thanks!

undersound3’s picture

undersound3 CreditAttribution: undersound3 commented

@Wim

I was trying to debug this today at drupalcon but I am unsure where to go from this function

public function submitForm(array &$form, FormStateInterface $form_state)
in core/modules/editor/src/Form/EditorImageDialog.php

I think this is a bit above my head but if I can be of any help or you can point me in some direction let me know.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Closed (duplicate)
Related issues: +#2347469: Rendering forms in AjaxResponses does not attach assets automatically

This is a duplicate of the more generic #2347469: Rendering forms in AjaxResponses does not attach assets automatically.

Thanks for reporting!

kattekrab’s picture

kattekrab CreditAttribution: kattekrab commented
Issue summary: View changes
kattekrab’s picture

kattekrab CreditAttribution: kattekrab commented
Status: Closed (duplicate) » Closed (fixed)

fixed by #2347469: Rendering forms in AjaxResponses does not attach assets automatically

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
Issue tags: -accesibility +Accessibility